MenuTagMultiselectWidget unexpectedly removes card if invalid input is entered after the field loses focus
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Daimona
	Feb 23 2023, 7:13 PM

Description

Steps to replicate the issue (include links if applicable):

Go to the OOUI demo page https://doc.wikimedia.org/oojs-ui/master/demos/
Scroll to MenuTagMultiselectWidget (initially selected, preset options)
Type something invalid, e.g. "foobar"
Click outside of the field, so that it loses focus
Focus the field again by clicking
Hit enter

What happens?:
A card will disappear from the widget, and whatever you typed will also be cleared.

What should have happened instead?:
This I don't know. I would say that hitting enter should not change (add or remove) any cards; I guess the main question is what should happen to the invalid text, i.e., whether it should be cleared or not. Maybe it shouldn't, but again, I don't know for sure.

Software version (skip for WMF-hosted wikis like Wikipedia):
OOUI v0.46.3

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.47.0	mediawiki/core	master	+967 -272
	Improve confusing ENTER behavior in MenuTagMultiselectWidget	oojs/ui	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: T327470: Implementation - Multiple organizer support
T285252: MenuTagMultiselectWidget removes selected item when tabbing away
Mentioned Here: T295885: OOUI ComboBoxInputWidget (filtering on input) updates

Event Timeline

Daimona created this task.Feb 23 2023, 7:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2023, 7:13 PM

Daimona mentioned this in T285252: MenuTagMultiselectWidget removes selected item when tabbing away.Feb 23 2023, 7:14 PM

Daimona mentioned this in T327470: Implementation - Multiple organizer support.Feb 23 2023, 10:58 PM

thiemowmde subscribed.Feb 24 2023, 8:04 AM

Change 891811 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[oojs/ui@master] Improve confusing ENTER behavior in MenuTagMultiselectWidget

https://gerrit.wikimedia.org/r/891811

gerritbot added a project: Patch-For-Review.Feb 24 2023, 11:30 AM

This is not exactly an error. The same happens when you don't type anything. Just focus the field and hit enter.

What happens is that the dropdown menu opens with the first element being highlighted and pre-selected the same time. Enter toggles the selection for the currently highlighted item and either adds or removes it from the list of tags. The code responsible for this intended behavior can be seen here: https://gerrit.wikimedia.org/r/c/oojs/ui/+/891488/2/src/widgets/SelectWidget.js

The invalid, red text is entirely ignored in this situation and just disappears. What makes this confusing is that multiple things happen the same time.

Turns out this is related to T295885. I uploaded a patch where I suggest a slightly different behavior that should be easier to follow.

In T330424#8643886, @thiemowmde wrote:

This is not exactly an error. The same happens when you don't type anything. Just focus the field and hit enter.

What happens is that the dropdown menu opens with the first element being highlighted and pre-selected the same time. Enter toggles the selection for the currently highlighted item and either adds or removes it from the list of tags. The code responsible for this intended behavior can be seen here: https://gerrit.wikimedia.org/r/c/oojs/ui/+/891488/2/src/widgets/SelectWidget.js

Ooooooh, I see, you're right! This is indeed quite confusing. I guess it's fine if there's no "pending" input, but otherwise I didn't understand what was going on.

Change 891811 merged by jenkins-bot:

[oojs/ui@master] Improve confusing ENTER behavior in MenuTagMultiselectWidget

https://gerrit.wikimedia.org/r/891811

Maintenance_bot removed a project: Patch-For-Review.May 12 2023, 10:11 AM

Change 921070 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.47.0

https://gerrit.wikimedia.org/r/921070

gerritbot added a project: Patch-For-Review.May 18 2023, 5:16 PM

Change 921070 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.47.0

https://gerrit.wikimedia.org/r/921070

Maintenance_bot removed a project: Patch-For-Review.May 18 2023, 8:31 PM