MenuTagMultiselectWidget removes selected item when tabbing away
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	thiemowmde
	Jun 21 2021, 4:32 PM

Description

MenuTagMultiselectWidget loses the first selected item when you tab away from the field.

Steps to reproduce:

Go to the OOUI demo page https://doc.wikimedia.org/oojs-ui/master/demos/
Scroll to MenuTagMultiselectWidget (initially selected, preset options)
Focus the field with the two pre-selected items
Tab away with ⇥ (tab) or ⇧+⇥ (shift + tab)
The first selected item is deleted

Can also be experienced in production when using Advanced-Search while tabbing away from the namespace selection:

Go to e.g. https://de.wikipedia.org/wiki/Special:Search
Select multiple namespaces, e.g. simply click "All".
Now use the ⇥ (tab) and ⇧+⇥ (shift + tab) keys to focus and leave the namespace input field multiple times.
Every time the input field looses focus, the first selected namespace is deleted.

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.47.0	mediawiki/core	master	+967 -272
Fix MenuSelectWidget removing unexpected items when tabbing out	oojs/ui	master	+2 -2
docs: Improve documentation of `.chooseItem()` methods	oojs/ui	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned In: T330353: MenuTagMultiselectWidget duplicates card on click if allowDisplayInvalidTags is true
T327470: Implementation - Multiple organizer support
Mentioned Here: T330424: MenuTagMultiselectWidget unexpectedly removes card if invalid input is entered after the field loses focus

Event Timeline

thiemowmde created this task.Jun 21 2021, 4:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2021, 4:32 PM

thiemowmde moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.Jan 28 2022, 3:15 PM

WMDE-Fisch renamed this task from Navigating AdvancedSearch form with tab key deletes selected namespaces to MenuTagMultiselectWidget removes selected item when tabbing away.Feb 1 2022, 12:14 PM

WMDE-Fisch added a project: OOUI.

WMDE-Fisch updated the task description. (Show Details)

thiemowmde moved this task from Backlog to Priority backlog on the WMDE-TechWish-Maintenance board.Mar 14 2022, 9:51 AM

Daimona subscribed.Feb 23 2023, 12:31 AM

I also found a similar issue that may or may not have the same root cause as the one reported here:

Go to the same demo mentioned in the task description and focus the field
Type something invalid, e.g. "foobar"
Click outside of the field, so that it loses focus
Focus the field again by clicking
Hit enter

This also results in the first card being removed, and whatever you typed will also disappear.

Change 891488 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[oojs/ui@master] Fix MenuSelectWidget removing unexpected items when tabbing out

https://gerrit.wikimedia.org/r/891488

gerritbot added a project: Patch-For-Review.Feb 23 2023, 8:52 AM

thiemowmde claimed this task.Feb 23 2023, 8:52 AM

thiemowmde moved this task from Backlog to Reviewing on the OOUI board.

thiemowmde added projects: WMDE-TechWish-Sprint-2023-01-18, Unplanned-Sprint-Work.

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-01-18 board.

thiemowmde moved this task from Priority backlog to In progress on the WMDE-TechWish-Maintenance board.

thiemowmde added subscribers: Esanders, Volker_E, matmarex.

Change 891493 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[oojs/ui@master] Improve documentation of .chooseItem() methods

https://gerrit.wikimedia.org/r/891493

Change 891493 merged by jenkins-bot:

[oojs/ui@master] docs: Improve documentation of `.chooseItem()` methods

https://gerrit.wikimedia.org/r/891493

ldelench_wmf mentioned this in T327470: Implementation - Multiple organizer support.Feb 23 2023, 3:24 PM

Daimona mentioned this in T330353: MenuTagMultiselectWidget duplicates card on click if allowDisplayInvalidTags is true.Feb 23 2023, 4:51 PM

In T285252#8639378, @Daimona wrote:

I also found a similar issue that may or may not have the same root cause as the one reported here: [...]

This bug is not fixed by the patch above, so I'm assuming that the root cause is different, and I've filed a separate task for it: T330424.

Change 891488 merged by jenkins-bot:

[oojs/ui@master] Fix MenuSelectWidget removing unexpected items when tabbing out

https://gerrit.wikimedia.org/r/891488

Maintenance_bot removed a project: Patch-For-Review.Feb 24 2023, 2:10 PM

awight moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2023-01-18 board.Mar 1 2023, 8:29 AM

thiemowmde closed this task as Resolved.Mar 13 2023, 1:19 PM

Change 921070 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.47.0

https://gerrit.wikimedia.org/r/921070

gerritbot added a project: Patch-For-Review.May 18 2023, 5:16 PM

Change 921070 merged by jenkins-bot: