Page MenuHomePhabricator

HelpPanel: Close the panel when post-edit dialog or try new task dialog are shown
Closed, ResolvedPublic

Description

When the try new task (T322386: Leveling up: "Try a new task" dialog) dialog or the post-edit dialog are shown, it doesn't make sense to leave the help panel open. It can be distracting from the main CTA which is in the dialog. Let's close it when we are opening the post-edit/try-new-task dialogs. The user can always open it again as needed.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 891843 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] PostEdit: Close help panel when post-edit or try new task panels are shown

https://gerrit.wikimedia.org/r/891843

without patch (status quo)with patch (close the help panel)
close-panel.gif (911×1 px, 1 MB)
close-panel.gif (911×1 px, 792 KB)

@RHo @JFernandez-WMF what do you think?

without patch (status quo)with patch (close the help panel)
close-panel.gif (911×1 px, 1 MB)
close-panel.gif (911×1 px, 792 KB)

@RHo @JFernandez-WMF what do you think?

Seems fine to me. In mobile, the help panel has to be closed to advance in publishing the edit anyway so this tracks too.

Change 891843 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] PostEdit: Close help panel when post-edit or try new task panels are shown

https://gerrit.wikimedia.org/r/891843

kostajh triaged this task as Medium priority.Mar 1 2023, 8:30 PM

Change 894754 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: check if help panel is loaded before closing

https://gerrit.wikimedia.org/r/894754

Change 894754 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: check if help panel is loaded before closing

https://gerrit.wikimedia.org/r/894754