Page MenuHomePhabricator

Mobile section-level ... button displays even when it doesn't have anything to show
Open, Needs TriagePublicBUG REPORT


Steps to replicate the issue (include links if applicable):

What happens?:
There are ... buttons on the non-discussion sections which, when clicked, do nothing.

image.png (538×798 px, 66 KB)

What should have happened instead?:
Should also have contained the "edit" link that other section menus contain.

Event Timeline

ppelberg added a subscriber: ppelberg.

Great spot, @DLynch.

Per what we discussed in triage, sections of this sort (no comments contained within them) should still have section edit links present alongside them.

ppelberg updated the task description. (Show Details)
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

Change 896133 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Allow overflow from section containers on mobile

We could probably merge this into T330536 -- turns out that the menu does contain the edit link, it's just that the clipping effect combines with the size of the non-discussion section heading perfectly to make it look like no menu is being shown.

(Unless we'd rather go further and replace the "..." button entirely with an "edit" button for these sections.)

Change 896133 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Allow overflow from section containers on mobile

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
DLynch added a project: Editing QA.
EAkinloose added a subscriber: EAkinloose.

IMG_FC0421CC6909-1.jpeg (2×1 px, 651 KB)

The button displays a tooltip with the edit link as expected