Page MenuHomePhabricator
Create Task
Maniphest T330536

Mobile section-level ... button and associated menu is cut off by the section container
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The highlight and menu are cut off by the section container

image.png (606×794 px, 62 KB)

What should have happened instead?:
The highlight and menu should probably escape the container and display overlapping other content.

Other information (browser name/version, screenshots, etc.):
I've tried this in Chrome, Safari, and iOS Safari and it seems to behave the same everywhere.

Details

SubjectRepoBranchLines +/-
Allow overflow from section containers on mobilemediawiki/extensions/DiscussionToolsmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

DLynch created this task.Feb 24 2023, 10:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2023, 10:13 PM
ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Mar 9 2023, 4:35 PM
ppelberg added subscribers: Esanders, ppelberg.

Per what @Esanders in triage, let's try to: see if we can turn off the "clipping" so that the button outline is visible. We'll do this knowing there's a possibility that it could introduce other bugs at which point we'll need to decide which we're more will to accept: this issue or the unnamed issues fixing could introduce.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Mar 9 2023, 4:35 PM
gerritbot added a comment.Mar 9 2023, 4:50 PM

Change 896133 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Allow overflow from section containers on mobile

https://gerrit.wikimedia.org/r/896133

gerritbot added a project: Patch-For-Review.Mar 9 2023, 4:50 PM
DLynch mentioned this in T330537: Mobile section-level ... button displays even when it doesn't have anything to show.Mar 9 2023, 4:54 PM
DLynch added a comment.Mar 9 2023, 5:02 PM

Patchdemo: https://patchdemo.wmflabs.org/wikis/56e9396b0e/wiki/Talk:DiscussionTools?useformat=mobile

DLynch moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Mar 9 2023, 5:58 PM
gerritbot added a comment.Mar 9 2023, 10:54 PM

Change 896133 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Allow overflow from section containers on mobile

https://gerrit.wikimedia.org/r/896133

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2023, 11:10 PM
DLynch claimed this task.Mar 9 2023, 11:12 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
DLynch added a project: Editing QA.
matmarex moved this task from Inbox to High Priority on the Editing QA board.Mar 15 2023, 3:31 PM
EAkinloose edited projects, added Verified; removed Editing QA.Mar 20 2023, 4:46 PM
EAkinloose subscribed.

Button and highlight menu isn't cut off by the section container. It displays as expected

IMG_FC0421CC6909-1.jpeg (2×1 px, 651 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Mar 20 2023, 4:47 PM
matmarex closed this task as Resolved.Apr 3 2023, 6:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits