Page MenuHomePhabricator

"Show IP" button hover background overlaps full stop on Special:Thanks
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Find a temporary account edit or make one
  • Log into an account that can view temporary account IPs
  • Load Special:Thanks for the edit made by the temporary account
  • Thank them for the edit
  • Hover over the button to show the IP

What happens?:
Notice that the full stop is included inside the background colour shown when hovering over the link

What should have happened instead?:
Not too sure, but not sure it looks good to have the full stop be included inside the background colour when the button is being hovered over.

Software version (skip for WMF-hosted wikis like Wikipedia):
Latest CheckUser, Thanks and core code.

Other information (browser name/version, screenshots, etc.):
Example:

image.png (426×1 px, 41 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1064131 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/CheckUser@master] Correct overlap of "Show IP" button

https://gerrit.wikimedia.org/r/1064131

I couldn't reproduce the issue with the provided steps, presumably because the styling of the temporary user name has changed since the ticket was opened. However, I was able to reproduce a very similar issue on Special:RecentChanges where semicolons following the "Show IP" button overlapped. I made a patch that removes the negative margin from the "Show IP" button to correct this. One downside I have noticed is that the spacing between the button and the semicolon looks uneven when not hovered on.

I couldn't reproduce the issue with the provided steps, presumably because the styling of the temporary user name has changed since the ticket was opened. However, I was able to reproduce a very similar issue on Special:RecentChanges where semicolons following the "Show IP" button overlapped. I made a patch that removes the negative margin from the "Show IP" button to correct this. One downside I have noticed is that the spacing between the button and the semicolon looks uneven when not hovered on.

Thanks for the patch and notes, @Amdrel. Could you please post screenshots with the before/after showing the potential downside you noted, for @KColeman-WMF to review?

Thanks for the patch and notes, @Amdrel. Could you please post screenshots with the before/after showing the potential downside you noted, for @KColeman-WMF to review?

Sure thing!

Before:

Screenshot 2024-08-21 at 8.18.11 AM.png (198×1 px, 109 KB)

After:

Screenshot 2024-08-21 at 8.17.54 AM.png (200×1 px, 110 KB)

Thanks for the patch and notes, @Amdrel. Could you please post screenshots with the before/after showing the potential downside you noted, for @KColeman-WMF to review?

Sure thing!

Before:

Screenshot 2024-08-21 at 8.18.11 AM.png (198×1 px, 109 KB)

After:

Screenshot 2024-08-21 at 8.17.54 AM.png (200×1 px, 110 KB)

cc @KColeman-WMF, does the "After" screeenshot look OK to you?

JayCano set the point value for this task to 1.Aug 26 2024, 10:22 AM

Thanks @Amdrel! I see what you mean about the spacing looking uneven but on balance I think it's fine, as we don't appear to have an alternative solution if we want to fix the grey background issue.

Change #1064131 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Correct overlap of "Show IP" button

https://gerrit.wikimedia.org/r/1064131

Djackson-ctr subscribed.

QA has been completed and the new code is functioning and displaying as expected.

image.png (69×1 px, 56 KB)