Hi,

Quick question on policy. As you know, V22 has broken a lot of functionality within Grade C browsers, and some of these problems have even appeared after the original roll-out, i.e. following casual tweaks that endeavour to improve its functionality. I raised a question in February about the Search bar's accelerator key (F) having broken (archived [[https://en.wikipedia.org/wiki/Wikipedia:Help_desk/Archives/2023_February_7#Search_Box_AccessKey_[f]_not_working_with_new_skin_in_Firefox | here]]) and one of the old-timers (TheDJ) seemed to suggest the policy was, essentially, that there would be no obligation to ensure basic functionality for older browsers, and if new designs broke on them, so be it. I see however that the official Browser Support Matrix currently mandates support for Firefox 39+, moreover @ovasileva's change of priority here suggests such loss of functionality is indeed treated as serious.

So, should we be raising things like broken accelerator keys as bugs, and am I safe to assume that any change to a given feature that appears in both V22 and V10, yet breaks in V22 in Grade C browsers, should be considered a flaw that warrants correcting?

Thanks

@Jimmy_GigaPod if you see the "basic functionality" definition at https://www.mediawiki.org/wiki/Compatibility#Basic_(Grade_C) it states "In the front-end this means content is presented in a readable manner."
So the only thing mandated for Firefox 39+ is that a reader can read the content. So no, bugs around access keys for searching would not be considered.

I think in the case here the table of contents should likely be considered "content" (hence the high priority) but I think that policy could be clarified around that to make it clearer what we consider content.

Hi @Jdlrobson, thanks for clarifying the distinction. That makes sense, and I agree with your definition of the ToC as content. In that page I also see a few references, but no definition for, Grade B browsers, which it would seem fill that twilight zone between Grade C (content only) and Grade A (bells & whistles). Judging by historic versions of the page, it looks like they were once defined, so reckon we should have either:

• the (re)introduction of a dynamic definition for Grade B (continued support for features that were supported "yesterday" (e.g. accelerators), but not new features (e.g. some crazy 3D map of the information universe), or
• removal of references to this Grade B in the Compatibility page so that all we potential Grade B browsers who enter here may safely & assuredly abandon hope.

Change 897968 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure the TOC works across all pinned/unpinned cases when JS is disabled

https://gerrit.wikimedia.org/r/897968

For whoever picks up this task for code review, please reach out to me to chat about the AC and testing for this!

Hi @bwang,

Thanks for dealing with this. If the change needs testing I'm happy to do it, but please note I'm new, so don't know the process and may not have the rights tools. We'll need to ensure @Jdlrobson is happy with it too, as he raised this issue first, but if there's any testing work you need here, just let me know. Thanks.

Change 897968 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure the TOC works across all pinned/unpinned cases when JS is disabled

https://gerrit.wikimedia.org/r/897968

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: When js is disabled for anon users above 1000px, the TOC is visible in the sidebar

✅ AC2: When js is disabled for anon users below 1000px, the TOC is in a dropdown in the page titlebar

✅ AC3: When js is disabled for a logged in user with the TOC initially pinned above 1000px, the TOC is visible in the sidebar

✅ AC4: When js is disabled for a logged in user with the TOC initially pinned below 1000px, the TOC is in a dropdown in the page titlebar

✅ AC5: When js is disabled for a logged in user with the TOC initially unpinned above 1000px, the TOC is in a dropdown in the page titlebar

✅ AC6: When js is disabled for a logged in user with the TOC initially unpinned below 1000px, the TOC is in a dropdown in the page titlebar

@Edtadros Thanks!