Page MenuHomePhabricator
Create Task
Maniphest T332393

Selenium Jenkins jobs fail after updating @wdio npm packages to v8
Closed, ResolvedPublic
Actions

Description

866386 updates @wdio npm packages in core to v8. Both selenium jobs (wmf-quibble-selenium-php74-docker and mediawiki-quibble-selenium-vendor-mysql-php74-docker) in CI fail after timing out.

Tests run fine on my machine using both node v16 (P45889) and node v14 (P45888).

Looks like something changed in wdio v8. The latest v7 (v7.30.2, 901566) runs just fine in CI, the first v8 (v8.0.0, 901567) fails.

This might be connected to T313899: Fresh problem when running Selenium tests. My local container sometimes gets stuck like this.

Notes

Details

SubjectRepoBranchLines +/-
WIP selenium: Upgrade WebdriverIO to v8mediawiki/coremaster+6 K -6 K
WIP selenium: Update @wdio to v8.0.0mediawiki/coremaster+4 K -1 K
WIP selenium: update @wdio to v7.30.2mediawiki/coremaster+1 K -714
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin renamed this task from wmf-quibble-selenium-php74-docker and mediawiki-quibble-selenium-vendor-mysql-php74-docker fail after updating wdio to v8 to wmf-quibble-selenium-php74-docker and mediawiki-quibble-selenium-vendor-mysql-php74-docker fail after updating @wdio npm packages to v8.Mar 17 2023, 1:22 PM
zeljkofilipin created this task.
zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin updated the task description. (Show Details)Mar 17 2023, 1:25 PM
zeljkofilipin added a parent task: T324766: Upgrade WebdriverIO to v8 in core.
zeljkofilipin updated the task description. (Show Details)Mar 17 2023, 1:36 PM
gerritbot added a comment.Mar 17 2023, 1:39 PM

Change 866386 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/866386

gerritbot added a project: Patch-For-Review.Mar 17 2023, 1:39 PM
zeljkofilipin triaged this task as High priority.Mar 20 2023, 12:30 PM
Jdforrester-WMF removed a parent task: T324766: Upgrade WebdriverIO to v8 in core.Mar 20 2023, 3:18 PM
Jdforrester-WMF added subtasks: T324766: Upgrade WebdriverIO to v8 in core, T324685: Upgrade WebdriverIO to v8 in all repositories.
Jdforrester-WMF subscribed.

This isn't blocking the "do the work", this is blocked by it.

zeljkofilipin updated the task description. (Show Details)Mar 20 2023, 4:45 PM
zeljkofilipin renamed this task from wmf-quibble-selenium-php74-docker and mediawiki-quibble-selenium-vendor-mysql-php74-docker fail after updating @wdio npm packages to v8 to Selenium Jenkins jobs fail after updating @wdio npm packages to v8.Mar 21 2023, 10:49 AM
zeljkofilipin mentioned this in T313899: Fresh problem when running Selenium tests.
zeljkofilipin added a comment.EditedMar 21 2023, 12:03 PM
In T332393#8710498, @Jdforrester-WMF wrote:

This isn't blocking the "do the work", this is blocked by it.

@Jdforrester-WMF: I didn't understand that. This task is blocking T324766: Upgrade WebdriverIO to v8 in core and T324685: Upgrade WebdriverIO to v8 in all repositories.

gerritbot added a comment.Mar 21 2023, 12:10 PM

Change 901566 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] WIP selenium: update @wdio to v7.30.2

https://gerrit.wikimedia.org/r/901566

gerritbot added a comment.Mar 21 2023, 12:15 PM

Change 901567 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] WIP selenium: Update @wdio to v8.0.0

https://gerrit.wikimedia.org/r/901567

Jdforrester-WMF added a comment.Mar 21 2023, 12:36 PM
In T332393#8714383, @zeljkofilipin wrote:
In T332393#8710498, @Jdforrester-WMF wrote:

This isn't blocking the "do the work", this is blocked by it.

@Jdforrester-WMF: I didn't understand that. This task is blocking T324766: Upgrade WebdriverIO to v8 in core and T324685: Upgrade WebdriverIO to v8 in all repositories.

How? This task is "These tests are broken until we've done the work to upgrade to v8", right?

zeljkofilipin updated the task description. (Show Details)Mar 21 2023, 12:39 PM
gerritbot added a comment.Mar 21 2023, 12:56 PM

Change 901566 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: update @wdio to v7.30.2

Reason:

https://gerrit.wikimedia.org/r/901566

gerritbot added a comment.Mar 21 2023, 1:32 PM

Change 901567 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Update @wdio to v8.0.0

Reason:

https://gerrit.wikimedia.org/r/901567

zeljkofilipin added a comment.Mar 21 2023, 2:51 PM
In T332393#8714496, @Jdforrester-WMF wrote:

How? This task is "These tests are broken until we've done the work to upgrade to v8", right?

No. I've updated wdio in core to v8 and everything works fine on my machine, but the job timeouts in CI. I don't know why, yet. So, v8 upgrade is blocked on fixing CI.

zeljkofilipin changed the task status from Open to In Progress.Mar 21 2023, 3:57 PM
zeljkofilipin updated the task description. (Show Details)Mar 21 2023, 4:05 PM
zeljkofilipin updated the task description. (Show Details)
gerritbot added a comment.Mar 24 2023, 11:56 AM

Change 866386 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

Reason:

https://gerrit.wikimedia.org/r/866386

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2023, 12:10 PM
zeljkofilipin changed the task status from In Progress to Open.Mar 24 2023, 12:12 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from High to Needs Triage.
zeljkofilipin changed the status of subtask T324766: Upgrade WebdriverIO to v8 in core from In Progress to Open.
zeljkofilipin removed subtasks: T324685: Upgrade WebdriverIO to v8 in all repositories, T324766: Upgrade WebdriverIO to v8 in core.
zeljkofilipin added a parent task: T324766: Upgrade WebdriverIO to v8 in core.
zeljkofilipin moved this task from Deep work 🌊 to Backlog 🪒 on the User-zeljkofilipin board.
gerritbot added a comment.Oct 13 2023, 11:59 AM

Change 866386 restored by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/866386

gerritbot added a project: Patch-For-Review.Oct 13 2023, 11:59 AM
Jdforrester-WMF added a comment.Oct 13 2023, 12:30 PM
In T332393#8715164, @zeljkofilipin wrote:
In T332393#8714496, @Jdforrester-WMF wrote:

How? This task is "These tests are broken until we've done the work to upgrade to v8", right?

No. I've updated wdio in core to v8 and everything works fine on my machine, but the job timeouts in CI. I don't know why, yet. So, v8 upgrade is blocked on fixing CI.

Huh, how odd!

zeljkofilipin changed the task status from Open to In Progress.Oct 13 2023, 1:24 PM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as High priority.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin changed the task status from In Progress to Open.Oct 27 2023, 10:21 AM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from High to Needs Triage.
zeljkofilipin moved this task from Deep work 🌊 to Q3 👔 on the User-zeljkofilipin board.
zeljkofilipin mentioned this in T347137: Update wdio-mediawiki to work with both WebdriverIO v7 and v8.Oct 31 2023, 4:00 PM
zeljkofilipin changed the task status from Open to In Progress.Nov 7 2023, 2:36 PM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as High priority.
zeljkofilipin moved this task from Q3 👔 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin added a subscriber: • Peter.

@Peter thinks using chromium explicitly could help. Supported in v8.20.3.

• Peter added a comment.Nov 8 2023, 6:40 AM

I think the problem was that when we use Chrome devtools protocol to drive the tests, you need to specify Chromium. If we use Chromedriver, it will pick up whatever kind of Chrome that's installed.

zeljkofilipin changed the task status from In Progress to Open.Nov 24 2023, 4:10 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from High to Needs Triage.
zeljkofilipin moved this task from Deep work 🌊 to Q3 👔 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Q3 👔 to Backlog 🪒 on the User-zeljkofilipin board.Jan 19 2024, 1:03 PM
gerritbot added a comment.Feb 14 2024, 3:11 PM

Change 866386 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

Reason:

Moved to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/966447

https://gerrit.wikimedia.org/r/866386

gerritbot added a comment.Feb 15 2024, 11:41 AM

Change 866386 restored by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/866386

zeljkofilipin changed the task status from Open to In Progress.Feb 15 2024, 11:57 AM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as High priority.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin closed this task as Resolved.Feb 19 2024, 12:06 PM

This problem (CI job timing out after an hour) is fixed 866386/39.

WMDE-Fisch awarded a token.Feb 19 2024, 12:14 PM
gerritbot added a comment.Feb 20 2024, 4:59 PM

Change 866386 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

Reason:

https://gerrit.wikimedia.org/r/866386

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits