Page MenuHomePhabricator
Create Task
Maniphest T332664

Kartotherian "Cannot read property 'coordinates' of null"
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

We got ~3k errors a day when we sort points from north to south for cases where mapdata does not return the expected format [1].

Cannot read property 'coordinates' of null

and

Cannot read property '1' of undefined

https://gerrit.wikimedia.org/g/mediawiki/services/kartotherian/+/d9a586276bce77f60e0cb0c3de9ba5ddb4b1e07a/lib/snapshot/mapdataLoader.js#80

Details

SubjectRepoBranchLines +/-
Don't attempt to sort features with no coordinatesmediawiki/services/kartotherianmaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Mar 21 2023, 7:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2023, 7:21 AM
WMDE-Fisch renamed this task from Regression: Kartotherian "Cannot read property 'coordinates' of null" to Kartotherian "Cannot read property 'coordinates' of null".Mar 21 2023, 7:21 AM
WMDE-Fisch added a parent task: T326290: Update error analysis after deploying robustness and logging improvements.
WMDE-Fisch added a project: Regression.
gerritbot added a comment.Mar 21 2023, 8:57 AM

Change 901538 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/services/kartotherian@master] Don't attempt to sort features with no coordinates

https://gerrit.wikimedia.org/r/901538

gerritbot added a project: Patch-For-Review.Mar 21 2023, 8:57 AM
thiemowmde claimed this task.Mar 21 2023, 8:58 AM
thiemowmde moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.
thiemowmde added projects: WMDE-TechWish-Sprint-2023-03-14, Unplanned-Sprint-Work.
thiemowmde changed the subtype of this task from "Task" to "Bug Report".
thiemowmde set the point value for this task to 2.
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-03-14 board.
WMDE-Fisch moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.Mar 22 2023, 9:59 AM
gerritbot added a comment.Mar 23 2023, 1:20 PM

Change 901538 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Don't attempt to sort features with no coordinates

https://gerrit.wikimedia.org/r/901538

thiemowmde mentioned this in rMSKA9bfa4de439b9: Don't attempt to sort features with no coordinates.Mar 23 2023, 1:25 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 23 2023, 1:30 PM
WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2023-03-14 board.Mar 23 2023, 1:48 PM
WMDE-Fisch added a parent task: T331977: Deploy recent map server work to production ( May 2023 ).
Stashbot mentioned this in T329924: Update kartotherian to use mapdata 0.9.0 (external data is expanded in-place).Aug 1 2023, 5:05 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-01T17:05:19Z] <mbsantos@deploy1002> Started deploy [kartotherian/deploy@ee544cb]: Update kartotherian to e28ea7ef (T334668 T332985 T332664 T329924)

Stashbot mentioned this in T334668: Host sprites and glyphs in kartotherian for Android WebGL map.Aug 1 2023, 5:05 PM
Stashbot mentioned this in T332985: Reduce kartotherian empty group logspam caused by Wikivoyage.
Stashbot added a comment.Aug 1 2023, 5:09 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-01T17:09:44Z] <mbsantos@deploy1002> Finished deploy [kartotherian/deploy@ee544cb]: Update kartotherian to e28ea7ef (T334668 T332985 T332664 T329924) (duration: 04m 25s)

WMDE-Fisch closed this task as Resolved.Aug 7 2023, 5:15 PM
WMDE-Fisch removed thiemowmde as the assignee of this task.
WMDE-Fisch added a subscriber: thiemowmde.

Deployment is done. Logspam resolved.

WMDE-Fisch mentioned this in T331977: Deploy recent map server work to production ( May 2023 ).Aug 7 2023, 5:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits