Page MenuHomePhabricator
Create Task
Maniphest T334668

Host sprites and glyphs in kartotherian for Android WebGL map
Closed, ResolvedPublic
Actions

Description

Background Information

As part of an investigation, the Android team decided to move forward with a maplibre implementation of the WMF map, see T324068#8585806 for more details. In order to allow this we need to support glyphs and sprites not yet supported.

What

Support the following endpoints to serve glyphs and sprites:

"sprite": "https://petersongis.github.io/Mobility/wikisprites",
"glyphs": "https://petersongis.github.io/Mobility/fonts/{fontstack}/{range}.pbf",

How

TBD

Acceptance Criteria

  • The Android App can use the maplibre style with all assets hosted in the WMF infrastructure

Details

SubjectRepoBranchLines +/-
Add LICENSE for wikispritesmediawiki/services/kartotherianmaster+5 -0
add glyphs to kartotherian for webglmediawiki/services/kartotherianmaster+7 K -0
add sprites to kartotherianmediawiki/services/kartotherianmaster+41 K -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

MSantos created this task.Apr 13 2023, 1:15 PM
MSantos removed Gpeterson as the assignee of this task.Apr 13 2023, 1:18 PM
ARamadan-WMF subscribed.Apr 13 2023, 5:01 PM
Jgiannelos triaged this task as Medium priority.Apr 27 2023, 2:07 PM
Jgiannelos removed a project: Product-Infrastructure-Team-Backlog-Deprecated.
MSantos claimed this task.May 22 2023, 7:39 AM
MSantos moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.May 22 2023, 11:15 AM
gerritbot added a comment.May 22 2023, 5:43 PM

Change 922154 had a related patch set uploaded (by MSantos; author: MSantos):

[mediawiki/services/kartotherian@master] add glyphs and sprites to kartotherian

https://gerrit.wikimedia.org/r/922154

gerritbot added a project: Patch-For-Review.May 22 2023, 5:43 PM
MSantos moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.May 22 2023, 5:46 PM
MSantos added subscribers: Seddon, JTannerWMF, Dbrant.
gerritbot added a comment.Jun 12 2023, 10:46 AM

Change 929176 had a related patch set uploaded (by MSantos; author: MSantos):

[mediawiki/services/kartotherian@master] add glyphs to kartotherian for webgl

https://gerrit.wikimedia.org/r/929176

MSantos added a project: Essential-Work.Jun 19 2023, 11:24 AM
MSantos added a parent task: T336146: [EPIC] FY 23-24 unplanned and maintenance for Content Transform Team.
MSantos moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Jun 26 2023, 3:25 PM
gerritbot added a comment.Jul 20 2023, 9:44 AM

Change 922154 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] add sprites to kartotherian

https://gerrit.wikimedia.org/r/922154

gerritbot added a comment.Jul 20 2023, 9:44 AM

Change 929176 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] add glyphs to kartotherian for webgl

https://gerrit.wikimedia.org/r/929176

MSantos mentioned this in rMSKAe28ea7eff64d: add glyphs to kartotherian for webgl.Jul 20 2023, 9:46 AM
MSantos mentioned this in rMSKA158f56fcf2f4: add sprites to kartotherian.
Maintenance_bot removed a project: Patch-For-Review.Jul 20 2023, 10:10 AM
TheDJ added a comment.Jul 20 2023, 1:48 PM

Can someone double check for license issues and ensure that if there is a license that doesn't match this repo, there is a LICENSE file in the subdir at least ? Or if the license is CC-by-sa or something, add that in the README ? These things tend to get overlooked and then later on it's hard to correct/find back.

MSantos added a comment.Aug 1 2023, 4:19 PM

@TheDJ thanks for raising that. The only font used is Open Sans which is Apache 2.0. I'll pull the LICENSE text into the repo and add that comment to the README.

The sprites are pulled from osm-bright.tm2 the default style used by WMF maps. Anything that should be noted about that?

Stashbot mentioned this in T329924: Update kartotherian to use mapdata 0.9.0 (external data is expanded in-place).Aug 1 2023, 5:05 PM
Stashbot mentioned this in T332664: Kartotherian "Cannot read property 'coordinates' of null".

Mentioned in SAL (#wikimedia-operations) [2023-08-01T17:05:19Z] <mbsantos@deploy1002> Started deploy [kartotherian/deploy@ee544cb]: Update kartotherian to e28ea7ef (T334668 T332985 T332664 T329924)

Stashbot mentioned this in T332985: Reduce kartotherian empty group logspam caused by Wikivoyage.Aug 1 2023, 5:05 PM
Stashbot added a comment.Aug 1 2023, 5:09 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-01T17:09:44Z] <mbsantos@deploy1002> Finished deploy [kartotherian/deploy@ee544cb]: Update kartotherian to e28ea7ef (T334668 T332985 T332664 T329924) (duration: 04m 25s)

TheDJ added a comment.Aug 2 2023, 8:15 AM

https://github.com/kartotherian/osm-bright.tm2/blob/master/LICENSE.txt

Code is BSD, Design of the map is CC-by-3.0, icons are CC0 1.0 (all by both Mapbox and Wikimedia Foundation). I would just copy the icons part of the above license file and put it in a license file that is inside the same directory as the icons.

WMDE-Fisch mentioned this in T331977: Deploy recent map server work to production ( May 2023 ).Aug 7 2023, 5:17 PM
MSantos moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Aug 21 2023, 3:10 PM
gerritbot added a comment.Aug 28 2023, 11:30 AM

Change 952833 had a related patch set uploaded (by MSantos; author: MSantos):

[mediawiki/services/kartotherian@master] Add LICENSE for wikisprites

https://gerrit.wikimedia.org/r/952833

gerritbot added a project: Patch-For-Review.Aug 28 2023, 11:30 AM
gerritbot added a comment.Sep 6 2023, 8:18 AM

Change 952833 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Add LICENSE for wikisprites

https://gerrit.wikimedia.org/r/952833

Maintenance_bot removed a project: Patch-For-Review.Sep 6 2023, 8:31 AM
MSantos mentioned this in rMSKA53b9441638a4: Add LICENSE for wikisprites.Sep 6 2023, 8:56 AM
MSantos closed this task as Resolved.Sep 6 2023, 2:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits