Page MenuHomePhabricator

Roll back geoshape expansion experiments
Closed, ResolvedPublic

Description

Unfortunately, we weren't able to complete this feature within our time frame, and the remaining work is significant. Most importantly, we saw a performance regression when briefly deploying, probably caused by MediaWiki parsing revisions multiple times. We also haven't solved the migration questions, since geoshape expansion will change the inline mapframe content hashes and therefore will cause breakage.

We'll remove the code for now:

  • Remove geoshape expansion from the Kartographer extension.
  • Remove the feature flags from mediawiki-config.

Event Timeline

awight renamed this task from [Epic] Roll back geoshape expansion experiments to Roll back geoshape expansion experiments.Mar 24 2023, 9:04 AM
awight created this task.

Change 902669 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] Remove external geoshape expansion

https://gerrit.wikimedia.org/r/902669

Change 902670 had a related patch set uploaded (by Awight; author: Awight):

[operations/mediawiki-config@master] [beta] remove flag for experimental mapdata geoshape expansion

https://gerrit.wikimedia.org/r/902670

Change 905162 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Remove now unused expensive parser function instrumentation

https://gerrit.wikimedia.org/r/905162

Change 902669 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove external geoshape expansion

https://gerrit.wikimedia.org/r/902669

Change 905162 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove now unused expensive parser function instrumentation

https://gerrit.wikimedia.org/r/905162

Change 902670 merged by jenkins-bot:

[operations/mediawiki-config@master] [beta] remove flag for experimental mapdata geoshape expansion

https://gerrit.wikimedia.org/r/902670

thiemowmde claimed this task.