Page MenuHomePhabricator

Button to add a new sense should not be capitalized via CSS
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

  • The capitalization or non-capitalization of strings like this must be left up to the translators.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

I tried to figure out where this CSS rule came from, but didn’t find much in T165567 or T160053; my suspicion is that the design screenshots, e.g. in T160053#3344681, happened to use initial-uppercase labels for the buttons, and that Aleksey added the text-transform: capitalize to match this, but that it wasn’t really a conscious decision at any point.

Maybe @Lydia_Pintscher or @Sarai-WMDE can make a quick decision here? (Technically, the patch looks fine and should be ready to +2 at any time.)

That sounds like a reasonable explanation, but we definitely make sure that:

The capitalization or non-capitalization of strings like this must be left up to the translators.

As mentioned in the task description. So, LGTUX.

Change 902850 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Jon Harald Søby):

[mediawiki/extensions/WikibaseLexeme@master] Remove text-transform: capitalize;

https://gerrit.wikimedia.org/r/902850

Change 902850 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Remove text-transform: capitalize;

https://gerrit.wikimedia.org/r/902850

Lucas_Werkmeister_WMDE set the point value for this task to 1.

Should be deployed with this week’s train.

Arian_Bozorg subscribed.

Looks good to me :)

Thanks so much @jhsoby