Page MenuHomePhabricator

Search preview keyboard navigation breaks in certain cases
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open a search preview using keyboard navigation (tab key)
  • Navigate to various parts of the preview using keyboard (tab key)
  • Navigate until the end of the contents in preview using keyboard

What happens?:

When the end of contents in preview is reached, the tab navigation should cycle back to "Close" button in the search preview. This is what happens in all cases except the case below:

If the "+ X sections" link is the last link within the search preview contents, then the tab navigation behaves differently. Instead of cycling back to top (i.e. to close button) it navigates to the footer. See video below that shows the expected behaviour first and then the unexpected behaviour in the second example.

Link to video

What should have happened instead?:

It should navigate back to the close button and not leave the preview focus.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Checked in production the navigation for cases where are some parts of a quick preview are not present, i.e.

  • Sections in the article
  • + [n] more sections
  • View more
  • interwiki links

Tab navigation seems to be working as expected. So far, I could not find in production) a case where only Sections in the article and + [n] more sections are present. I'll test more tab navigation on different wikis (all my testing was so far on ptwiki).

Change 921026 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Search preview keyboard navigation breaks in certain cases

https://gerrit.wikimedia.org/r/921026

Change 921026 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Search preview keyboard navigation breaks in certain cases

https://gerrit.wikimedia.org/r/921026

Thanks @Etonkovidova for checking. I saw that in beta so perhaps its working as expected in production now. The examples you provided it works as expected.

Thanks @Etonkovidova for checking. I saw that in beta so perhaps its working as expected in production now. The examples you provided it works as expected.

Thx, @Sneha! ( re-checked again in wmf.15 (the recent deployment) - the navigation works as expected.