Page MenuHomePhabricator
Create Task
Maniphest T333476

Link provided by collation of multiple new topic notifications does not link somewhere sensible
Closed, ResolvedPublic
Actions

Description

In this notification:

image.png (683×520 px, 119 KB)

the individual notifications link to the sections they created, but the top group ("6 new topics on..") links to

https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&dtnewcommentssince=c-Timeshifter-20230328185900-Same_names_for_SVG_and_PNG_versions_of_same_map&dtinthread=1&markasread=276888015%7C276879510%7C276829756%7C276825721%7C276810350%7C276806850&markasreadwiki=enwiki#Incorrect_preview_images

(which is copied from the comment notifications code).

It shows new comments "since" the oldest one in the group, but only highlights one comment as dtinthread=1 limits it to one thread.

Removing dtinthread=1 would also highlight new comments in threads other than the new ones, which is also incorrect:
https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&dtnewcommentssince=c-Timeshifter-20230328185900-Same_names_for_SVG_and_PNG_versions_of_same_map&markasread=276888015%7C276879510%7C276829756%7C276825721%7C276810350%7C276806850&markasreadwiki=enwiki#Incorrect_preview_images

Details

SubjectRepoBranchLines +/-
New topics notifications: Only highlight comments in new threadsmediawiki/extensions/DiscussionToolsmaster+18 -2
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 29 2023, 5:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2023, 5:50 PM
Esanders updated the task description. (Show Details)Mar 29 2023, 5:50 PM
Esanders claimed this task.Mar 30 2023, 4:05 PM
Esanders added a project: Editing-team (Kanban Board).
Esanders moved this task from Backlog to Triaged on the DiscussionTools board.
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Mar 30 2023, 4:07 PM

Change 904570 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] New topics notifications: Only highlight comments in new threads

https://gerrit.wikimedia.org/r/904570

gerritbot added a project: Patch-For-Review.Mar 30 2023, 4:07 PM
gerritbot added a comment.Mar 30 2023, 9:33 PM

Change 904570 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] New topics notifications: Only highlight comments in new threads

https://gerrit.wikimedia.org/r/904570

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Mar 30 2023, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 30 2023, 10:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Apr 7 2023, 7:44 PM
matmarex added a project: Editing QA.
EAkinloose subscribed.Apr 21 2023, 10:17 PM

✅ Link provided by collation of multiple new topic notifications takes the user to the newly created topics with the description highlighted

Screenshot 2023-04-21 at 23.02.01.png (1×2 px, 260 KB)

❓For mobile, it takes me to the talk page and I have to scroll down to see the newly created topics. Also they are not highlighted. See behaviour.

Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Apr 24 2023, 11:54 PM
Ryasmeen removed a project: Editing QA.
matmarex moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.May 8 2023, 5:21 PM
matmarex subscribed.
In T333476#8799029, @EAkinloose wrote:

❓For mobile, it takes me to the talk page and I have to scroll down to see the newly created topics. Also they are not highlighted. See behaviour.

Filed T336190

matmarex moved this task from Ready to Be Worked On to Blocked / Needs More Work on the Editing-team (Kanban Board) board.May 8 2023, 5:23 PM
EAkinloose added a comment.May 8 2023, 5:54 PM
In T333476#8834241, @matmarex wrote:
In T333476#8799029, @EAkinloose wrote:

❓For mobile, it takes me to the talk page and I have to scroll down to see the newly created topics. Also they are not highlighted. See behaviour.

Filed T336190

This can be verified and closed then. Thanks!

matmarex closed this task as Resolved.May 8 2023, 8:23 PM
matmarex moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.

Thanks for checking!

EAkinloose added a project: Verified.May 9 2023, 12:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL