I thought there was one already which is currently set to not enable the existing datatype.

In T333666#8745028, @Lydia_Pintscher wrote:

I thought there was one already which is currently set to not enable the existing datatype.

Yes, I think there is a config in Wikibase that can turn Datatypes off. But, to be honest, I would feel safer if we had a (temporary) config designed to not even enable it in the first place over something that just disables it. That way, we also catch places where we might forget to set this config (What is exactly is the value of that config on commons and test-commons?).

Further, I'm not fully sure if that config also applies to valuetypes or if Wikibase has an analogous config that does?

Lastly, we would need to actually set this config in production. Having such a config in EntitySchema that defaults to "off" should allow us to skip that.

Change 905192 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Create feature flag config for new EntitySchema Datatype

https://gerrit.wikimedia.org/r/905192

In T333666#8746158, @Michael wrote:

In T333666#8745028, @Lydia_Pintscher wrote:

I thought there was one already which is currently set to not enable the existing datatype.

Yes, I think there is a config in Wikibase that can turn Datatypes off. But, to be honest, I would feel safer if we had a (temporary) config designed to not even enable it in the first place over something that just disables it. That way, we also catch places where we might forget to set this config (What is exactly is the value of that config on commons and test-commons?).

Further, I'm not fully sure if that config also applies to valuetypes or if Wikibase has an analogous config that does?

Lastly, we would need to actually set this config in production. Having such a config in EntitySchema that defaults to "off" should allow us to skip that.

Ok. My main worry is that we're getting conflicting and confusing config options for Wikibase admins. If we can ensure that that's not happening at the end I'm fine.

In T333666#8750373, @Lydia_Pintscher wrote:

[...]

Ok. My main worry is that we're getting conflicting and confusing config options for Wikibase admins. If we can ensure that that's not happening at the end I'm fine.

Yes, I think that feature flag is intended to be purely internal and temporary. I already created T333667 to remove it again once we're done with this focus. External Wikibase admins should never have to deal with that.

Change 905192 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Create feature flag config for new EntitySchema Datatype

https://gerrit.wikimedia.org/r/905192