Add validator to EntitySchema data type definition
Closed, ResolvedPublic
Actions

Description

The validator should enforce:

that the value matches the pattern for an EntitySchema ID (make sure the match is case-sensitive too!); and
that an EntitySchema with this ID actually exists (it may be deleted later, but we should enforce existence at the time the value is created).

Compare e.g. the validator-factory-callback of PT:commonsMedia in WikibaseRepo.datatypes.php.

	Subject	Repo	Branch	Lines +/-
	Add EntitySchemaExistsValidator	mediawiki/extensions/EntitySchema	master	+204 -13
	Set up initial validators for entity-schema data type	mediawiki/extensions/EntitySchema	master	+137 -5

Status	Assigned	Task
Open	None	T91505 [Epic] Adding new datatypes to Wikidata (tracking)
Open	None	T214884 [ES-M2]: [EPIC] Linking EntitySchemas in statements
Resolved	karapayneWMDE	T332139 [ES-M2]: Create a new EntitySchema data type
Resolved	Lucas_Werkmeister_WMDE	T333813 Add validator to EntitySchema data type definition

Taking this over from Marius, since he’s OoO for a few days and this blocks T332725: [ES-M2]: Enable new EntitySchema data type on Beta Wikidata; I hope that’s okay.

Change 908846 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Set up initial validators for entity-schema data type

Change 908893 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] WIP: Add EntitySchemaExistsValidator

Change 908846 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Set up initial validators for entity-schema data type

Change 908893 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Add EntitySchemaExistsValidator

Nice and easy, thank you \o/