Page MenuHomePhabricator

Fix font issues in Babel extension
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):

  1. Now pt are used to form the text. Although there must be em
  2. The text size (10,6px) of the template description does not match the size of the allowed minimum text (12px).

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

Benefits (why should this be implemented?):
This is necessary to improve accessibility.

BeforeAfter
image.png (380×277 px, 30 KB)
image.png (373×267 px, 30 KB)

Event Timeline

Change 905981 had a related patch set uploaded (by Iniquity; author: Iniquity):

[mediawiki/extensions/Babel@master] Increasing the template description text and changing the text dimension

https://gerrit.wikimedia.org/r/905981

@MarcoAurelio Are you requesting code review or what did you have in mind when tagging us?

Could you provide resources that confirm that going from pt to em is recommended?

@Nikerabbit pt together with px are absolute value units. They are blocking one of the most used accessibility features in browsers, to upscale interface via user font size settings. And should therefore not be used in Wikimedia contexts.
See

image.png (756×1 px, 125 KB)

“Message group” here is set to 14pt. Browser font size setting in this example is 32px default (Firefox).

Additionally it would make sense to go for standard unit em in our interfaces from standardization perspective. In order to identify different and with that possibly inconsistent values.

@Iniquity a screenshot before/after would be good in task description. Happy to merge otherwise.

@MarcoAurelio Are you requesting code review or what did you have in mind when tagging us?

Hello. I tagged the team for Code Review since it is listed as the code steward for Babel. Thanks.

Nikerabbit triaged this task as Lowest priority.Apr 24 2023, 1:51 PM

Interesting. I have a memory that Editing team was listed there before. It looks like there are volunteers to review it already, but I'm adding to our sprint as low priority just in case nody gets to it before us.

@Iniquity a screenshot before/after would be good in task description. Happy to merge otherwise.

Oh, yes :)

BeforeAfter
image.png (380×277 px, 30 KB)
image.png (373×267 px, 30 KB)

Change 905981 merged by jenkins-bot:

[mediawiki/extensions/Babel@master] Increase font size of template description text and change the text dimension

https://gerrit.wikimedia.org/r/905981

Wangombe subscribed.

Screen Shot 2023-05-15 at 16.10.20 PM.png (234×615 px, 56 KB)

Tested on translatewiki.net