Page MenuHomePhabricator

Noicon parameter for audio files is broken
Closed, ResolvedPublic

Description

The noicon parameter for audio files is broken in Mediawiki 1.18.


Version: 1.18.x
Severity: normal

Details

Reference
bz31415

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:49 PM
bzimport added a project: MediaWiki-General.
bzimport set Reference to bz31415.
bzimport added a subscriber: Unknown Object (MLST).
Yair_rand created this task.Oct 6 2011, 7:35 AM
demon added a comment.Oct 6 2011, 2:30 PM

What is the noicon parameter? Could you provide a link to what's not working? (along with a clear description of what the expected behavior is)

brion added a comment.Oct 6 2011, 6:18 PM

all the info there seems to have been hidden in a collapsed comment. :P

It seems the parameter |noicon in the code
[[File:Accordian chords-01.ogg|noicon|right]]
is no longer observed; vide:
noicon

The template {{Listen/core}} issues this parameter and ignoring it changes the appearance of {{Listen}}. What caused this change and how can it be reverted? -- Michael Bednarek (talk) 13:27, 6 October 2011 (UTC)

'noicon' seems to be a special magic word that OggHandler understands which can be used to disable the little 'info' icon that links to the file info page.

Handling still seems to be there, not sure offhand what would have broken it.

TheDJ added a comment.Oct 6 2011, 11:11 PM

hmm, remember that a while ago I activated input param validation that was already present, to actually do validation, somewhere in a few media handlers ? Perhaps this is one of the keywords that is not in the validator list ?

brion added a comment.Oct 6 2011, 11:15 PM

Bingo, that looks suspicious -- in r87923 you tweaked OggHandler::validateParam to check width, height, and thumbtime properly (for bug 28886) but it's not checking anything for 'noicon'. Should be easy to add...

brion added a comment.Oct 6 2011, 11:20 PM

Fixed on trunk in r99167.

tagging bugs for Marcus to look at