VisualEditorFeatureUse validation errors
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Apr 6 2023, 12:16 AM

Description

In T333168#8759865, @phuedx wrote:

The above change was reverted in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/905979 and the revert was deployed at around 15:15 UTC today. I reverted because the number of VisualEditorFeatureUse validation errors increased and I don't have time to investigate them now. Of note is that there was only one normalised validation error message:

'.event.integration' should be string, '.event.integration' should be equal to one of the allowed values, '.event.editor_interface' should be string, '.event.editor_interface' should be equal to one of the allowed values

@matmarex: Could this have something to do with the recent refactoring of the EditAttemptStep and VisualEditorFeatureUse instruments? [https://gerrit.wikimedia.org/r/q/topic:centralize-editattemptstep]

In T333168#8761190, @matmarex wrote:

That sounds likely, thanks for the note. The events in your link are logged with null values for "editor_interface" and "integration", and the refactoring changed how the defaults for these fields are defined.

Details

	Subject	Repo	Branch	Lines +/-
	Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged	mediawiki/extensions/WikimediaEvents	wmf/1.41.0-wmf.4	+24 -8
	Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged	mediawiki/extensions/WikimediaEvents	master	+24 -8

Customize query in gerrit

Related Objects

Mentioned In: T119117: Get rid of $wg = $wmg hack for extensions that have been converted to using extension.json
T332438: Centralize EditAttemptStep logging code in WikimediaEvents
T322602: "Invalid revision ID -1" error for VisualEditorFeatureUse events, mostly from officewiki
Mentioned Here: T119117: Get rid of $wg = $wmg hack for extensions that have been converted to using extension.json
T333168: Increase VisualEditorFeatureUse sampling rate to 100%

Event Timeline

matmarex created this task.Apr 6 2023, 12:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2023, 12:16 AM

Many of the problematic events are logged for features that only exist in ContentTranslation ("cxLink"), so this is probably the problem (or at least one of the problems). I'm not sure if previously we didn't log VisualEditorFeatureUse events in it at all, or if we logged them with some incorrect values for "editor_interface" and "integration". We need to figure out if/how they should be logged.

matmarex updated the task description. (Show Details)Apr 6 2023, 12:20 AM

matmarex mentioned this in T322602: "Invalid revision ID -1" error for VisualEditorFeatureUse events, mostly from officewiki.Apr 6 2023, 7:07 PM

Event logging in in ContentTranslation was previously prevented by this check:

		if ( ve.init.target && (
			ve.init.target.constructor.static.platformType !== 'desktop'
		) ) {
			// We want to log activity events when we're also logging to
			// EditAttemptStep. The EAS events are only fired from DesktopArticleTarget
			// in this repo. As such, we suppress this unless the current target is at
			// least inheriting that. (Other tools may fire their own instances of
			// those events, but probably need to reimplement this anyway for
			// session-identification reasons.)
			return;
		}

(removed here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/900759/6/modules/ve-mw/init/ve.init.mw.trackSubscriber.js#b284)

matmarex claimed this task.Apr 6 2023, 7:27 PM

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.

Change 906653 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikimediaEvents@master] Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged

https://gerrit.wikimedia.org/r/906653

gerritbot added a project: Patch-For-Review.Apr 6 2023, 8:02 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Apr 6 2023, 8:02 PM

Check logs after deployment, I think.

Change 906653 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged

https://gerrit.wikimedia.org/r/906653

Maintenance_bot removed a project: Patch-For-Review.Apr 11 2023, 3:30 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 11 2023, 4:00 PM

matmarex added a project: MediaWiki-extensions-WikimediaEvents.Apr 11 2023, 8:24 PM

matmarex mentioned this in T332438: Centralize EditAttemptStep logging code in WikimediaEvents.Apr 11 2023, 8:27 PM

Change 907743 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikimediaEvents@wmf/1.41.0-wmf.4] Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged

https://gerrit.wikimedia.org/r/907743

gerritbot added a project: Patch-For-Review.Apr 11 2023, 8:37 PM

Change 907743 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.41.0-wmf.4] Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged

https://gerrit.wikimedia.org/r/907743

Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:48:40Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:907743|Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged (T334157)]], [[gerrit:905751|Stop using redundant $wmg variable for MobileFrontend extension (T119117)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:50:01Z] <urbanecm@deploy2002> urbanecm and matmarex: Backport for [[gerrit:907743|Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged (T334157)]], [[gerrit:905751|Stop using redundant $wmg variable for MobileFrontend extension (T119117)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:55:07Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:907743|Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged (T334157)]], [[gerrit:905751|Stop using redundant $wmg variable for MobileFrontend extension (T119117)]] (duration: 06m 26s)