The $wgFoo = $wmgFoo hack was needed for extensions because InitialiseSettings.php would run before extensions were loaded, so the extension defaults would overwrite the wanted values. But extension.json doesn't unconditionally set defaults if they're already set, so we don't need this hack anymore!
Example change: https://gerrit.wikimedia.org/r/#/c/237686/
This will reduce the amount of globals we use, and hopefully will help a little with T103886.
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Open | None | T119117 Get rid of $wg = $wmg hack for extensions that have been converted to using extension.json | ||
| Resolved | None | T140852 Load all Wikimedia-deployed extensions and skins via extension registration | ||
| · · · |
Looks good! At the same time, we should also change the require_once invocation to wfLoadExtension and update extension-list if they haven't been updated already.
Ideally, we should deploy this change extension per extension to allow test with a disruption limited to at most one extension, shouldn't we?
Agreed.
Change 266470 had a related patch set uploaded (by Dereckson):
Get rid of $wg = $wmg for BetaFeatures
Change 268627 had a related patch set uploaded (by Dereckson):
Use extension registration for CategoryTree
Change 270145 had a related patch set uploaded (by Dereckson):
Use extension registration for Math
Change 279268 had a related patch set uploaded (by Dereckson):
Use extension registration for Cite
Change 279371 had a related patch set uploaded (by Dereckson):
Enable extension registration for InputBox
Change 279372 had a related patch set uploaded (by Dereckson):
Enable extension registration for ParserFunctions
Change 279294 merged by jenkins-bot:
Update extension-list for extension registration
Change 279372 merged by jenkins-bot:
Enable extension registration for ParserFunctions
Change 280223 had a related patch set uploaded (by Dereckson):
Use extension registration for ImageMap
Change 280224 had a related patch set uploaded (by Dereckson):
Use extension registration for SyntaxHighlight_GeSHi
Change 280225 had a related patch set uploaded (by Dereckson):
Use extension registration for DoubleWiki
Change 280226 had a related patch set uploaded (by Dereckson):
Use extension registration for Poem
Change 280227 had a related patch set uploaded (by Dereckson):
Use extension registration for UnicodeConverter
Change 280224 merged by jenkins-bot:
Use extension registration for SyntaxHighlight_GeSHi
Change 280242 had a related patch set uploaded (by Dereckson):
Use extension registration for DoubleWiki
Change 281237 had a related patch set uploaded (by Dereckson):
Use extension registration for LabeledSectionTransclusion
Change 281239 had a related patch set uploaded (by Dereckson):
Use extension registration for SpamBlacklist
Change 281240 had a related patch set uploaded (by Dereckson):
Use extension registration for TitleBlacklist
Change 281242 had a related patch set uploaded (by Dereckson):
Use extension registration for Quiz
Change 281243 had a related patch set uploaded (by Dereckson):
Use extension registration for FundraisingTranslateWorkflow
Change 281244 had a related patch set uploaded (by Dereckson):
Use extension registration for Gadgets
Change 281246 had a related patch set uploaded (by Dereckson):
Use extension registration for MwEmbedSupport
Change 281303 had a related patch set uploaded (by Dereckson):
Use extension registration for ExtensionDistributor
Change 281311 had a related patch set uploaded (by Dereckson):
Use extension registration for GlobalBlocking
Change 281976 had a related patch set uploaded (by Dereckson):
Use extension registration for ProofreadPage
We've a backlog of changes to merge.
I've moved back to the backlog as anybody can take one of the dozens remaining extension include to migrate.
Mentioned in SAL [2016-06-01T23:49:49Z] <dereckson@tin> Synchronized wmf-config/CommonSettings.php: Use extension registration for SpamBlacklist (T119117) (duration: 00m 24s)
Mentioned in SAL [2016-06-01T23:51:30Z] <dereckson@tin> Synchronized wmf-config/CommonSettings.php: Revert Use extension registration for SpamBlacklist (T119117) (duration: 00m 24s)
Change 292312 had a related patch set uploaded (by Dereckson):
Use extension registration for SpamBlacklist
Change 281237 merged by jenkins-bot:
Use extension registration for LabeledSectionTransclusion
Mentioned in SAL [2016-06-30T15:53:33Z] <thcipriani@tin> Synchronized wmf-config: SWAT: [[gerrit:281237|Use extension registration for LabeledSectionTransclusion (T119117)]] (duration: 00m 27s)
Mentioned in SAL [2016-06-30T16:15:43Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:281240|Use extension registration for TitleBlacklist (T119117)]] PART I (duration: 00m 39s)
Mentioned in SAL [2016-06-30T16:16:51Z] <thcipriani@tin> Synchronized wmf-config: SWAT: [[gerrit:281240|Use extension registration for TitleBlacklist (T119117)]] PART II (duration: 00m 36s)
Change 281243 merged by jenkins-bot:
Use extension registration for FundraisingTranslateWorkflow
Change 281303 merged by jenkins-bot:
Use extension registration for ExtensionDistributor
Change 502269 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Stop using wmg variables for Score extension
Change 502269 merged by jenkins-bot:
[operations/mediawiki-config@master] CommonSettings: Stop using wmg variables for Score extension
Change 905711 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[operations/mediawiki-config@master] Stop using redundant $wmg variables for VisualEditor extension (3/3)
Change 905751 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[operations/mediawiki-config@master] Stop using redundant $wmg variable for MobileFrontend extension (2/2)
Change 905751 merged by jenkins-bot:
[operations/mediawiki-config@master] Stop using redundant $wmg variable for MobileFrontend extension
Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:48:40Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:907743|Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged (T334157)]], [[gerrit:905751|Stop using redundant $wmg variable for MobileFrontend extension (T119117)]]
Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:50:01Z] <urbanecm@deploy2002> urbanecm and matmarex: Backport for [[gerrit:907743|Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged (T334157)]], [[gerrit:905751|Stop using redundant $wmg variable for MobileFrontend extension (T119117)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet
Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:55:07Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:907743|Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged (T334157)]], [[gerrit:905751|Stop using redundant $wmg variable for MobileFrontend extension (T119117)]] (duration: 06m 26s)
Change 905711 merged by jenkins-bot:
[operations/mediawiki-config@master] Stop using redundant $wmg variables for VisualEditor extension
Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:17:31Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:905711|Stop using redundant $wmg variables for VisualEditor extension (T119117)]]
Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:18:49Z] <urbanecm@deploy2002> urbanecm and matmarex: Backport for [[gerrit:905711|Stop using redundant $wmg variables for VisualEditor extension (T119117)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet
Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:25:50Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:905711|Stop using redundant $wmg variables for VisualEditor extension (T119117)]] (duration: 08m 19s)