Page MenuHomePhabricator

Get rid of $wg = $wmg hack
Open, LowPublic

Description

The $wgFoo = $wmgFoo hack was needed for extensions because InitialiseSettings.php would run before extensions were loaded, so the extension defaults would overwrite the wanted values. But extension.json doesn't unconditionally set defaults if they're already set, so we don't need this hack anymore!

Example change: https://gerrit.wikimedia.org/r/#/c/237686/

This will reduce the amount of globals we use, and hopefully will help a little with T103886.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
SomeRandomDeveloperoperations/mediawiki-configmaster+5 -9
Ladsgroupoperations/mediawiki-configmaster+3 -7
Ladsgroupoperations/mediawiki-configmaster+3 -5
Ladsgroupoperations/mediawiki-configmaster+3 -7
Ladsgroupoperations/mediawiki-configmaster+1 -5
Urbanecmoperations/mediawiki-configmaster+1 -2
Bartosz Dziewońskioperations/mediawiki-configmaster+8 -29
Bartosz Dziewońskioperations/mediawiki-configmaster+0 -10
Lucas Werkmeister (WMDE)operations/mediawiki-configmaster+1 -3
Derecksonoperations/mediawiki-configmaster+11 -3
Derecksonoperations/mediawiki-configmaster+1 -1
Derecksonoperations/mediawiki-configmaster+2 -3
Derecksonoperations/mediawiki-configmaster+1 -1
Derecksonoperations/mediawiki-configmaster+1 -1
Derecksonoperations/mediawiki-configmaster+1 -1
Derecksonoperations/mediawiki-configmaster+1 -1
Derecksonoperations/mediawiki-configmaster+3 -3
Derecksonoperations/mediawiki-configmaster+1 -1
Derecksonoperations/mediawiki-configmaster+7 -5
Derecksonoperations/mediawiki-configmaster+2 -2
Derecksonoperations/mediawiki-configmaster+3 -2
Derecksonoperations/mediawiki-configmaster+2 -2
Derecksonoperations/mediawiki-configmaster+2 -2
Derecksonoperations/mediawiki-configmaster+2 -2
Derecksonoperations/mediawiki-configmaster+2 -2
Derecksonoperations/mediawiki-configmaster+2 -2
Derecksonoperations/mediawiki-configmaster+2 -2
Derecksonoperations/mediawiki-configmaster+2 -2
Derecksonoperations/mediawiki-configmaster+2 -2
Derecksonoperations/mediawiki-configmaster+3 -3
Derecksonoperations/mediawiki-configmaster+1 -1
Derecksonoperations/mediawiki-configmaster+1 -4
Derecksonoperations/mediawiki-configmaster+9 -11
Derecksonoperations/mediawiki-configmaster+6 -11
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 281976 had a related patch set uploaded (by Dereckson):
Use extension registration for ProofreadPage

https://gerrit.wikimedia.org/r/281976

We've a backlog of changes to merge.

I've moved back to the backlog as anybody can take one of the dozens remaining extension include to migrate.

Change 281239 merged by jenkins-bot:
Use extension registration for SpamBlacklist

https://gerrit.wikimedia.org/r/281239

Mentioned in SAL [2016-06-01T23:49:49Z] <dereckson@tin> Synchronized wmf-config/CommonSettings.php: Use extension registration for SpamBlacklist (T119117) (duration: 00m 24s)

Mentioned in SAL [2016-06-01T23:51:30Z] <dereckson@tin> Synchronized wmf-config/CommonSettings.php: Revert Use extension registration for SpamBlacklist (T119117) (duration: 00m 24s)

Change 292312 had a related patch set uploaded (by Dereckson):
Use extension registration for SpamBlacklist

https://gerrit.wikimedia.org/r/292312

Change 281237 merged by jenkins-bot:
Use extension registration for LabeledSectionTransclusion

https://gerrit.wikimedia.org/r/281237

Mentioned in SAL [2016-06-30T15:53:33Z] <thcipriani@tin> Synchronized wmf-config: SWAT: [[gerrit:281237|Use extension registration for LabeledSectionTransclusion (T119117)]] (duration: 00m 27s)

Change 281240 merged by jenkins-bot:
Use extension registration for TitleBlacklist

https://gerrit.wikimedia.org/r/281240

Mentioned in SAL [2016-06-30T16:15:43Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:281240|Use extension registration for TitleBlacklist (T119117)]] PART I (duration: 00m 39s)

Mentioned in SAL [2016-06-30T16:16:51Z] <thcipriani@tin> Synchronized wmf-config: SWAT: [[gerrit:281240|Use extension registration for TitleBlacklist (T119117)]] PART II (duration: 00m 36s)

Change 281243 merged by jenkins-bot:
Use extension registration for FundraisingTranslateWorkflow

https://gerrit.wikimedia.org/r/281243

Change 292312 merged by jenkins-bot:
Use extension registration for SpamBlacklist

https://gerrit.wikimedia.org/r/292312

Change 281303 merged by jenkins-bot:
Use extension registration for ExtensionDistributor

https://gerrit.wikimedia.org/r/281303

Change 281246 merged by jenkins-bot:
Use extension registration for MwEmbedSupport

https://gerrit.wikimedia.org/r/281246

Change 281242 merged by jenkins-bot:
Use extension registration for Quiz

https://gerrit.wikimedia.org/r/281242

Change 281976 merged by jenkins-bot:
Use extension registration for ProofreadPage

https://gerrit.wikimedia.org/r/281976

Change 281244 merged by jenkins-bot:
Use extension registration for Gadgets

https://gerrit.wikimedia.org/r/281244

Change 281311 merged by jenkins-bot:
Use extension registration for GlobalBlocking

https://gerrit.wikimedia.org/r/281311

Change 268627 merged by jenkins-bot:
Use extension registration for CategoryTree

https://gerrit.wikimedia.org/r/268627

Change 502269 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Stop using wmg variables for Score extension

https://gerrit.wikimedia.org/r/502269

Change 502269 merged by jenkins-bot:
[operations/mediawiki-config@master] CommonSettings: Stop using wmg variables for Score extension

https://gerrit.wikimedia.org/r/502269

Change 905711 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Stop using redundant $wmg variables for VisualEditor extension (3/3)

https://gerrit.wikimedia.org/r/905711

Change 905751 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Stop using redundant $wmg variable for MobileFrontend extension (2/2)

https://gerrit.wikimedia.org/r/905751

Change 905751 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop using redundant $wmg variable for MobileFrontend extension

https://gerrit.wikimedia.org/r/905751

Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:48:40Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:907743|Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged (T334157)]], [[gerrit:905751|Stop using redundant $wmg variable for MobileFrontend extension (T119117)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:50:01Z] <urbanecm@deploy2002> urbanecm and matmarex: Backport for [[gerrit:907743|Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged (T334157)]], [[gerrit:905751|Stop using redundant $wmg variable for MobileFrontend extension (T119117)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:55:07Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:907743|Only log 'visualEditorFeatureUse' events if 'editAttemptStep' events are being logged (T334157)]], [[gerrit:905751|Stop using redundant $wmg variable for MobileFrontend extension (T119117)]] (duration: 06m 26s)

Change 905711 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop using redundant $wmg variables for VisualEditor extension

https://gerrit.wikimedia.org/r/905711

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:17:31Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:905711|Stop using redundant $wmg variables for VisualEditor extension (T119117)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:18:49Z] <urbanecm@deploy2002> urbanecm and matmarex: Backport for [[gerrit:905711|Stop using redundant $wmg variables for VisualEditor extension (T119117)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:25:50Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:905711|Stop using redundant $wmg variables for VisualEditor extension (T119117)]] (duration: 08m 19s)

Change #1115520 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Babel: Do not use a wmg variable for BabelDefaultLevel

https://gerrit.wikimedia.org/r/1115520

Change #1115520 merged by jenkins-bot:

[operations/mediawiki-config@master] Babel: Do not use a wmg variable for BabelDefaultLevel

https://gerrit.wikimedia.org/r/1115520

Mentioned in SAL (#wikimedia-operations) [2025-02-06T13:53:33Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1115518|Babel: Remove config that is now in community configuration (T385239)]], [[gerrit:1115520|Babel: Do not use a wmg variable for BabelDefaultLevel (T119117)]], [[gerrit:1117105|Babel: Merge back into InitialiseSettings.php (T385239)]]

Mentioned in SAL (#wikimedia-operations) [2025-02-06T13:56:12Z] <urbanecm@deploy2002> urbanecm: Backport for [[gerrit:1115518|Babel: Remove config that is now in community configuration (T385239)]], [[gerrit:1115520|Babel: Do not use a wmg variable for BabelDefaultLevel (T119117)]], [[gerrit:1117105|Babel: Merge back into InitialiseSettings.php (T385239)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-02-06T14:04:09Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1115518|Babel: Remove config that is now in community configuration (T385239)]], [[gerrit:1115520|Babel: Do not use a wmg variable for BabelDefaultLevel (T119117)]], [[gerrit:1117105|Babel: Merge back into InitialiseSettings.php (T385239)]] (duration: 10m 36s)

Ladsgroup renamed this task from Get rid of $wg = $wmg hack for extensions that have been converted to using extension.json to Get rid of $wg = $wmg hack.Jun 8 2026, 10:52 AM
Ladsgroup subscribed.

All extensions have been migrated to extension.json making the part in the title now redundant :)

Change #1314716 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[operations/mediawiki-config@master] Remove $wmg hacks for $wgBabelCentralDb and $wgPFEnableStringFunctions

https://gerrit.wikimedia.org/r/1314716

Change #1319162 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[operations/mediawiki-config@master] Remove $wmg hack for UploadStashMaxAge

https://gerrit.wikimedia.org/r/1319162

Change #1319162 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove $wmg hack for UploadStashMaxAge

https://gerrit.wikimedia.org/r/1319162

Mentioned in SAL (#wikimedia-operations) [2026-07-30T12:30:15Z] <ladsgroup@deploy1003> Started scap sync-world: Backport for [[gerrit:1319162|Remove $wmg hack for UploadStashMaxAge (T119117)]]

Mentioned in SAL (#wikimedia-operations) [2026-07-30T12:32:28Z] <ladsgroup@deploy1003> ladsgroup: Backport for [[gerrit:1319162|Remove $wmg hack for UploadStashMaxAge (T119117)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-07-30T12:37:06Z] <ladsgroup@deploy1003> Finished scap sync-world: Backport for [[gerrit:1319162|Remove $wmg hack for UploadStashMaxAge (T119117)]] (duration: 06m 51s)

Change #1320115 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[operations/mediawiki-config@master] Remove more $wmg = $wg hacks

https://gerrit.wikimedia.org/r/1320115

Change #1320115 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove more $wmg = $wg hacks

https://gerrit.wikimedia.org/r/1320115

Mentioned in SAL (#wikimedia-operations) [2026-08-03T10:42:46Z] <ladsgroup@deploy1003> Started scap sync-world: Backport for [[gerrit:1320115|Remove more $wmg = $wg hacks (T119117)]]

Mentioned in SAL (#wikimedia-operations) [2026-08-03T10:46:41Z] <ladsgroup@deploy1003> ladsgroup: Backport for [[gerrit:1320115|Remove more $wmg = $wg hacks (T119117)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-08-03T10:53:43Z] <ladsgroup@deploy1003> Finished scap sync-world: Backport for [[gerrit:1320115|Remove more $wmg = $wg hacks (T119117)]] (duration: 10m 57s)

Change #1324363 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[operations/mediawiki-config@master] Remove $wmg = $wg hacks in CentralAuth

https://gerrit.wikimedia.org/r/1324363

Change #1324363 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove $wmg = $wg hacks in CentralAuth

https://gerrit.wikimedia.org/r/1324363

Mentioned in SAL (#wikimedia-operations) [2026-08-11T17:18:42Z] <ladsgroup@deploy1003> Started scap sync-world: Backport for [[gerrit:1324361|Move FR config from IS.php to a dedicated file]], [[gerrit:1324363|Remove $wmg = $wg hacks in CentralAuth (T119117)]]

Mentioned in SAL (#wikimedia-operations) [2026-08-11T17:23:10Z] <ladsgroup@deploy1003> ladsgroup: Backport for [[gerrit:1324361|Move FR config from IS.php to a dedicated file]], [[gerrit:1324363|Remove $wmg = $wg hacks in CentralAuth (T119117)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-08-11T17:31:05Z] <ladsgroup@deploy1003> Finished scap sync-world: Backport for [[gerrit:1324361|Move FR config from IS.php to a dedicated file]], [[gerrit:1324363|Remove $wmg = $wg hacks in CentralAuth (T119117)]] (duration: 12m 23s)

Change #1324409 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[operations/mediawiki-config@master] Remove $wmg = $wg hacks in Collection

https://gerrit.wikimedia.org/r/1324409

Change #1324409 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove $wmg = $wg hacks in Collection

https://gerrit.wikimedia.org/r/1324409

Mentioned in SAL (#wikimedia-operations) [2026-08-12T23:11:24Z] <ladsgroup@deploy1003> Started scap sync-world: Backport for [[gerrit:1324409|Remove $wmg = $wg hacks in Collection (T119117)]]

Mentioned in SAL (#wikimedia-operations) [2026-08-12T23:13:33Z] <ladsgroup@deploy1003> ladsgroup: Backport for [[gerrit:1324409|Remove $wmg = $wg hacks in Collection (T119117)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-08-12T23:18:07Z] <ladsgroup@deploy1003> Finished scap sync-world: Backport for [[gerrit:1324409|Remove $wmg = $wg hacks in Collection (T119117)]] (duration: 06m 43s)