Page MenuHomePhabricator

Unit tests for wfLoadExtension @ operations/mediawiki-config
Open, Needs TriagePublic


We're currently progressively updating CommonSettings.php to load extensions through wfLoadExtension instead of former include, to comply with extension registration and get rid of wmg/wg hack (see T119117).

Humans are quite bad to spot typos when extensions path or name look coherent, but this is potentially very harmful for the servers, as any deployment could break (and actually broke) the servers.

To avoid this, we can add tests to CommonSettings.php (and CommonSettings-labs.php): any wfLoadExtension method call should be validated, to ensure it requires to load an actual extension.

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 2 2016, 12:18 AM
Dereckson updated the task description. (Show Details)Jun 2 2016, 12:19 AM
Dereckson added subscribers: Legoktm, ori.

Note: from local repo point of view, we're quite limited as we don't know from the repository what's really deployed in prod, but we can already compare with extension-list (as long as still available).

Some other actions tests apart could be valuable: use systematically a first sync with mw1017 to test such changes for example would allow to avoid to impact production.

Paladox added a subscriber: Paladox.Jun 2 2016, 1:25 AM
greg moved this task from On-going to Follow-up on the Wikimedia-Incident board.Jul 27 2016, 10:45 PM
greg added a subscriber: greg.Sep 29 2016, 7:41 PM

This follow-up task from an incident report has not been updated recently. If it is no longer valid, please add a comment explaining why. If it is still valid, please prioritize it appropriately relative to your other work. If you have any questions, feel free to ask me (Greg Grossmeier).