Page MenuHomePhabricator

DefaultView: Create Zero state for Function Call component
Closed, ResolvedPublic

Assigned To
Authored By
gengh
Apr 10 2023, 10:16 AM
Referenced Files
Restricted File
Apr 18 2023, 5:17 PM
Restricted File
Apr 18 2023, 5:16 PM
F36955625: image.png
Apr 18 2023, 5:08 PM
F36955621: image.png
Apr 18 2023, 5:08 PM
F36955613: image.png
Apr 18 2023, 5:08 PM
F36955611: image.png
Apr 18 2023, 5:08 PM
F36945810: Screenshot from 2023-04-10 12-13-48.png
Apr 10 2023, 10:16 AM
F36945808: Screenshot from 2023-04-10 12-13-11.png
Apr 10 2023, 10:16 AM

Description

Description

When creating a new Function call the component can be collapsed:

E.g. expanded and collapsed unselected function:

Screenshot from 2023-04-10 12-14-34.png (172×277 px, 6 KB)

Screenshot from 2023-04-10 12-15-11.png (57×153 px, 1 KB)

E.g. expanded and collapsed "if" function with unselected arguments:

Screenshot from 2023-04-10 12-13-11.png (429×466 px, 16 KB)

Screenshot from 2023-04-10 12-13-48.png (64×202 px, 2 KB)

Desired behavior/Acceptance criteria

  • Design a comprehensible and user-friendly empty state for Function Call
  • Implement Function Call empty state

Devices and Design (URLs or screenshots)

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Event Timeline

we initially started to look at how we handle the collapsed zero-blank state for strings, monolingual text, etc. and for those cases we designed a bespoke solution.

image.png (1×1 px, 107 KB)

so, we explored how might it be to have a similar bespoke approach for function calls to.

image.png (1×1 px, 116 KB)

while this approach might work for the function selection, it doesn't when there are multiple empty fields. so here it comes a proposal: what if we use the same function call collapse view, but with red "links" for the empty fields. where the link label is the placeholder text of the empty field/s?

{F36955632}

also, by tap/click on a red "link" we could then redirect contributions to the specific missing field, in the expanded view.

image.png (1×2 px, 140 KB)

what do you all think of such approach? any doubts, or concerns?

Change 910457 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Create blank state for ZObjectToString/ZFunctionCall

https://gerrit.wikimedia.org/r/910457

Change 910457 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Create blank state for ZObjectToString/ZFunctionCall

https://gerrit.wikimedia.org/r/910457