Page MenuHomePhabricator

Update all Codex workspaces to use Vite 4
Closed, ResolvedPublic

Description

Vite released Version 4 at the end of 2022 (which is built on top of Rollup 3). Most of Codex is still using Vite 3, but the Codex Docs are already on Vite 4 since Vitepress (which is still in Alpha) rapidly upgraded to the latest version of Vite.

This inconsistency between Vite versions has come up in the bug at T334222. Vite 4 handles Less syntax in a way that better supports the way our CSS-only icon buttons are styled, so upgrading to use Vite 4 everywhere will solve that particular issue.

However, Vite 3 -> Vite 4 has a number of breaking changes, documented here: https://vitejs.dev/guide/migration.html

The most important one from our perspective is probably the change in the baseline Safari support – Vite 4 drops Safari 13 support.

We should try to complete this upgrade in a timely fashion, but we should also do some QA testing to ensure that there is no adverse impact on users of Codex components.

Event Timeline

Restricted Application triaged this task as High priority. · View Herald TranscriptApr 10 2023, 10:48 PM

Change 906663 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build: Update Vite, Vitepress, and related libraries

https://gerrit.wikimedia.org/r/906663

Change 906663 merged by jenkins-bot:

[design/codex@main] build: Update Vite, Vitepress, and related libraries

https://gerrit.wikimedia.org/r/906663

Now that this patch has merged, I'd like to create a corresponding patch in VueTest that updates Codex to the latest build (built with Vite 4). We should then hit that page in something like BrowserStack and ensure that things continue to function as expected in all browsers we support.

I think we won't have any issues but best to verify.

Change 911932 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v0.9.0 to v0.9.1

https://gerrit.wikimedia.org/r/911932

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/9a9f20a61d/w

Catrope claimed this task.
Catrope reassigned this task from Catrope to egardner.
Catrope subscribed.

Change 911932 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.9.0 to v0.9.1

https://gerrit.wikimedia.org/r/911932

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/9a9f20a61d/w/

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/96eb6f6d82/w/

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/97ecb286bb/w/