Page MenuHomePhabricator

Add the name of the event creator in the error message in case an organizer tries to remove the event creator
Closed, ResolvedPublic

Description

Add the name of the event creator in case an organizer tries to remove the event creator

There is an error on OOUI that allows users to remove the event creator even when the tag is disabled.

We will add the username of the event creator, so in case the user remove the event creator by mistake (because of the OOUI error), the user knows who is the creator and can add it again to be able to edit the event registration

Event Timeline

Change 909000 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add the username of the event creator in the error message

https://gerrit.wikimedia.org/r/909000

@gonyeahialam I would like your thoughts on how the error message would look like, now that we will add the username of the event creator, for now I put it this way:
Before: You are not allowed to remove the event creator
Now: You are not allowed to remove the event creator (UserName)

@gonyeahialam I would like your thoughts on how the error message would look like, now that we will add the username of the event creator, for now I put it this way:
Before: You are not allowed to remove the event creator
Now: You are not allowed to remove the event creator (UserName)

Use this error message @cmelo:
"You cannot remove (UserName) because they are the event creator"

Just registering here, what we (me and @gonyeahialam) decide on slack, that message will be:
"You cannot remove (UserName) because this user is the event creator"
Thanks @gonyeahialam!

Noting that

"You cannot remove (UserName) because they are the event creator"

conflicts with

**"You cannot remove (UserName) because this user is the event creator"

Which one should we use? Also, if choosing the former, we should use the appropriate pronoun with {{GENDER}}, instead of unconditionally using "they".

We will use this one:
"You cannot remove (UserName) because this user is the event creator"

Change 909000 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add the username of the event creator in the error message

https://gerrit.wikimedia.org/r/909000

Event Creator username successfully added to error message in case an organizer tries to remove the event creator on english betacluster

Screenshot 2023-04-24 at 2.47.54 PM.png (400ร—1 px, 63 KB)

Screen Recording 2023-04-24 at 2.36.38 PM.gif (1ร—2 px, 3 MB)

@cmelo In testing this on arabic betacluster though it does not display the username in the error message.

Screen Recording 2023-04-24 at 3.18.01 PM.gif (1ร—2 px, 1 MB)

@cmelo In testing this on arabic betacluster though it does not display the username in the error message.

That's because the arabic translation still needs to be updated.

@cmelo why does the error message show at the top instead of below the field with the error?

@cmelo why does the error message show at the top instead of below the field with the error?

It is because this one happens after you submit the form, but this is an edge case that only happens because of a bug on OOUI

Screenshot 2023-04-26 at 8.36.23 PM.png (476ร—1 px, 67 KB)

Username (without parenthesis) is displaying in error message. Sending to design sign off.