Page MenuHomePhabricator
Create Task
Maniphest T334689

Ensure all Hook interfaces contain 'Hook' suffix in their names
Closed, ResolvedPublic
Actions

Description

Among the 600+ hooks in core/core-api, currently only two lack the 'Hook' suffix in their names.

This causes their doc link to fail on mediawiki.org, because Template:MediaWikiHook has hardcoded the suffix.

There should be a test or sniff to enforce this, lest more stuff breaks unexpectedly.

Details

SubjectRepoBranchLines +/-
HookRunner: Add test to ensure consistent Hook interfaces namingmediawiki/coremaster+15 -0
HookRunnerTest: Add exception for some hook interfacesmediawiki/extensions/CheckUsermaster+27 -0
Add Hook suffix to GetBlockErrorMessageKeyHookmediawiki/coreREL1_40+12 -5
Add Hook suffix to GetBlockErrorMessageKeyHookmediawiki/coremaster+12 -5
Add Hook suffix to ParserModifyImageHTMLHookmediawiki/coremaster+13 -3
Customize query in gerrit

Related Objects

Event Timeline

Mainframe98 created this task.Apr 13 2023, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2023, 6:07 PM
Ammarpad subscribed.Apr 13 2023, 10:19 PM

Here's another https://www.mediawiki.org/wiki/Manual:Hooks/ParserModifyImageHTML. These seem to be the only violation now.

Ammarpad renamed this task from The hook interface GetBlockErrorMessageKey is missing the Hook suffix to Ensure all Hook interfaces contain 'Hook' suffix in their names.Apr 15 2023, 7:23 PM
Ammarpad updated the task description. (Show Details)
gerritbot added a comment.Apr 15 2023, 7:46 PM

Change 908971 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] HookRunner: Add test to ensure consistent Hook interfaces naming

https://gerrit.wikimedia.org/r/908971

gerritbot added a project: Patch-For-Review.Apr 15 2023, 7:46 PM
Ammarpad mentioned this in T334813: Rename Hook interfaces that don't follow naming convention.Apr 16 2023, 2:26 PM
gerritbot added a comment.Apr 16 2023, 3:00 PM

Change 908985 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/CheckUser@master] HookRunnerTest: Add exception for some hook interfaces

https://gerrit.wikimedia.org/r/908985

gerritbot added a comment.Apr 16 2023, 5:24 PM

Change 908989 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Add Hook suffix to GetBlockErrorMessageKeyHook

https://gerrit.wikimedia.org/r/908989

gerritbot added a comment.Apr 16 2023, 5:32 PM

Change 908990 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Add Hook suffix to ParserModifyImageHTMLHook

https://gerrit.wikimedia.org/r/908990

gerritbot added a comment.Apr 17 2023, 3:37 PM

Change 908989 merged by jenkins-bot:

[mediawiki/core@master] Add Hook suffix to GetBlockErrorMessageKeyHook

https://gerrit.wikimedia.org/r/908989

gerritbot added a comment.Apr 17 2023, 3:37 PM

Change 908990 merged by jenkins-bot:

[mediawiki/core@master] Add Hook suffix to ParserModifyImageHTMLHook

https://gerrit.wikimedia.org/r/908990

gerritbot added a comment.Apr 17 2023, 3:56 PM

Change 909273 had a related patch set uploaded (by Jforrester; author: Umherirrender):

[mediawiki/core@REL1_40] Add Hook suffix to GetBlockErrorMessageKeyHook

https://gerrit.wikimedia.org/r/909273

Jdforrester-WMF closed this task as Resolved.Apr 17 2023, 3:56 PM
Jdforrester-WMF assigned this task to Umherirrender.
gerritbot added a comment.Apr 17 2023, 4:09 PM

Change 909273 merged by jenkins-bot:

[mediawiki/core@REL1_40] Add Hook suffix to GetBlockErrorMessageKeyHook

https://gerrit.wikimedia.org/r/909273

Umherirrender reopened this task as Open.Apr 17 2023, 4:14 PM
Umherirrender reassigned this task from Umherirrender to Ammarpad.
Umherirrender subscribed.

Let's wait for the test to get merged before closing.

gerritbot added a comment.Apr 20 2023, 5:11 PM

Change 908985 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] HookRunnerTest: Add exception for some hook interfaces

https://gerrit.wikimedia.org/r/908985

gerritbot added a comment.Apr 24 2023, 6:01 PM

Change 908971 merged by jenkins-bot:

[mediawiki/core@master] HookRunner: Add test to ensure consistent Hook interfaces naming

https://gerrit.wikimedia.org/r/908971

Umherirrender closed this task as Resolved.Apr 24 2023, 6:11 PM
Umherirrender removed a project: Patch-For-Review.
ReleaseTaggerBot added projects: MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL