Page MenuHomePhabricator

"Add topic" in mobile DiscussionTools overlaps categories
Closed, ResolvedPublic

Description

"Add topic" in mobile DiscussionTools overlaps categories.

Example: https://pl.m.wikipedia.org/wiki/Wikipedia:Kawiarenka/Kwestie_techniczne

pl.m.wikipedia.org_wiki_Wikipedia_Kawiarenka_Kwestie_techniczne(iPhone SE).png (1×750 px, 112 KB)

Event Timeline

In T328452 we apparently fixed this with the "Read as wiki page" button, but not with this one.

Change 958065 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix interaction of "Add topic" button with categories

https://gerrit.wikimedia.org/r/958065

Test cases to verify:

  1. Discussion page with categories, displaying both "Add topic" and "Read as wiki page" buttons – buttons shouldn't overlap categories
  2. Discussion page with categories, displaying only the "Add topic" button – button shouldn't overlap categories
  3. Discussion page with categories, displaying only the "Read as wiki page" button – button shouldn't overlap categories
  4. Discussion page with categories, displaying only the "Read as wiki page" button, because it's showing the talk page empty state instead of "Add topic" button – button shouldn't overlap categories
  5. Discussion page without categories, displaying any of the buttons – button(s) should touch, but not overlap, the "Last edited…" bar

Change 958065 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix interaction of "Add topic" button with categories

https://gerrit.wikimedia.org/r/958065