Page MenuHomePhabricator
Create Task
Maniphest T335287

Fix 'local exceptions for global preference' toggle in mobile Special:Preferences
Closed, ResolvedPublic
Actions

Assigned To
Func
Authored By
Samwalton9-WMF
Apr 24 2023, 1:26 PM
Tags
Referenced Files
F36961789: Screenshot 2023-04-24 at 14.27.19.png
Apr 24 2023, 1:27 PM
F36961787: Screenshot 2023-04-24 at 14.26.50.png
Apr 24 2023, 1:27 PM
Subscribers
Aklapper
Func
jsn.sherman
Masumrezarock100
Samwalton9-WMF
Scardenasmolinar
TheresNoTime

Description

When users have specified a preference should be global via Special:GlobalPreferences, they can set local exceptions (overrides) in Special:Preferences. In the new MinervaNeue design, this is not possible, as the toggle does not re-enable the form fields for the preference.

Steps to reproduce

In MinervaNeue:

  • Navigate to Special:GlobalPreferences
  • Check the box next to a preference and save
  • Navigate to the same preference at Special:Preferences
  • A toggle labeled "Set a local exception for this global preference." should display under this preference, for which form fields should be disabled
  • Activating this toggle does not re-enable the form fields above, but it should.

Checking the box in Vector re-enables the form fields:

Screenshot 2023-04-24 at 14.26.50.png (452×1 px, 115 KB)

Toggling in MinervaNeue does not:

Screenshot 2023-04-24 at 14.27.19.png (798×818 px, 133 KB)

Details

SubjectRepoBranchLines +/-
preferences: Follow-up to commit b2062d11mediawiki/coreREL1_40+5 -1
preferences: Use the new DOM element after infusionmediawiki/coremaster+1 -0
preferences: Sync states between hidden checkbox and toggle widgetsmediawiki/coreREL1_40+10 -8
preferences: Sync states between hidden checkbox and toggle widgetsmediawiki/coremaster+10 -8
Customize query in gerrit

Related Objects

Event Timeline

Samwalton9-WMF created this task.Apr 24 2023, 1:26 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptApr 24 2023, 1:26 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Samwalton9-WMF updated the task description. (Show Details)Apr 24 2023, 1:27 PM
Func subscribed.Apr 24 2023, 1:54 PM

Not only for local exceptions, this also happened to all fields with the disable-if param set. Including Allow emails from brand-new users which should only be enabled when Allow other users to email me is on.

gerritbot added a comment.Apr 24 2023, 2:56 PM

Change 910544 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] preferences: Sync states between hidden checkbox and toggle widgets

https://gerrit.wikimedia.org/r/910544

gerritbot added a project: Patch-For-Review.Apr 24 2023, 2:56 PM
jsn.sherman subscribed.EditedApr 24 2023, 3:07 PM

What projects still have the toggles showing in global preferences on minerva? I would expect them to use checkboxes instead since our quick fix for T334260: GlobalPreferences formatting is broken on mobile was deployed.

Samwalton9-WMF added a comment.Apr 24 2023, 3:08 PM
In T335287#8801916, @jsn.sherman wrote:

What projects still have the toggles showing in global preferences on minerva? I would expect them to use checkboxes instead since our quick fix for T334260: GlobalPreferences formatting is broken on mobile was deployed.

The toggles show in Special:Preferences after a global preference has been selected and saved.

jsn.sherman added a comment.Apr 24 2023, 3:10 PM

Ah, gotcha, I should have run through the reproduce steps before commenting. Thanks!

Samwalton9-WMF moved this task from Ready to Code review on the Moderator-Tools-Team (Kanban) board.Apr 24 2023, 6:09 PM
TheresNoTime removed a project: Community-Tech.Apr 24 2023, 7:52 PM
TheresNoTime subscribed.

Going to boldly assume this comes under Moderator Tools' scope of work and untag us — please feel free to re-tag if incorrect :-)

PatchDemoBot added a comment.Apr 25 2023, 5:44 PM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/37917f7ee2/w

Samwalton9-WMF added a comment.Apr 26 2023, 1:35 PM
In T335287#8805432, @PatchDemoBot wrote:

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/37917f7ee2/w

This looks good to me!

Scardenasmolinar moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Apr 27 2023, 3:07 PM
Scardenasmolinar subscribed.

Merged! Thanks for the quick fix @Func!

gerritbot added a comment.Apr 27 2023, 3:23 PM

Change 910544 merged by jenkins-bot:

[mediawiki/core@master] preferences: Sync states between hidden checkbox and toggle widgets

https://gerrit.wikimedia.org/r/910544

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2023, 3:30 PM
gerritbot added a comment.Apr 27 2023, 3:38 PM

Change 911805 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@REL1_40] preferences: Sync states between hidden checkbox and toggle widgets

https://gerrit.wikimedia.org/r/911805

gerritbot added a project: Patch-For-Review.Apr 27 2023, 3:38 PM
Jdforrester-WMF closed this task as Resolved.Apr 27 2023, 4:36 PM
Jdforrester-WMF assigned this task to Func.
gerritbot added a comment.Apr 27 2023, 4:50 PM

Change 911805 merged by jenkins-bot:

[mediawiki/core@REL1_40] preferences: Sync states between hidden checkbox and toggle widgets

https://gerrit.wikimedia.org/r/911805

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2023, 5:10 PM
gerritbot added a comment.May 9 2023, 3:28 PM

Change 916921 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] preferences: Use the new DOM element after infusion

https://gerrit.wikimedia.org/r/916921

gerritbot added a project: Patch-For-Review.May 9 2023, 3:28 PM
gerritbot added a comment.May 9 2023, 4:15 PM

Change 917732 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@REL1_40] preferences: Follow-up to commit b2062d11

https://gerrit.wikimedia.org/r/917732

gerritbot added a comment.May 9 2023, 4:21 PM

Change 916921 merged by jenkins-bot:

[mediawiki/core@master] preferences: Use the new DOM element after infusion

https://gerrit.wikimedia.org/r/916921

gerritbot added a comment.May 12 2023, 12:51 PM

Change 917732 merged by jenkins-bot:

[mediawiki/core@REL1_40] preferences: Follow-up to commit b2062d11

https://gerrit.wikimedia.org/r/917732

Maintenance_bot removed a project: Patch-For-Review.May 12 2023, 1:10 PM
ReleaseTaggerBot added projects: MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 12:02 AM
PatchDemoBot added a comment.May 16 2023, 4:10 PM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/37917f7ee2/w/

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL