The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:
static and adjust the usages (More infos at T332865).
Initial work was done in 090563ba5442eda424b4716bf234306d639c8a56
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | None | T255792 Quibble runs core:unit tests twice! | |||
| Open | None | T328919 Upgrade to PHPUnit 10 | |||
| Open | None | T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min | |||
| Open | None | T332865 PHPUnit data providers should be simple static functions that return plain data | |||
| Resolved | Dreamy_Jazz | T337159 Make PHPUnit dataProvider static in CheckUser tests | |||
| Resolved | Dreamy_Jazz | T346044 Remove CheckUserUnionQueryBuilder |
Change 926459 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Deal with remaining non-static data providers in phpunit tests
Change 926459 abandoned by Dreamy Jazz:
[mediawiki/extensions/CheckUser@master] Deal with remaining non-static data providers in phpunit tests
Reason:
Too many merge conflicts. Will re-create this.
Change 941899 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Make some of the non-static data providers static
Change 941899 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Make some of the non-static data providers static
Change 956450 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] clienthints: Make ::provideIncrementAndCheck static
There exist other data providers that are non-static in CheckUser, but they are for the now deprecated union query builder which will be removed soon and need some further work to be fixed. Therefore putting time into fixing those providers is not useful.
Change 956450 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] clienthints: Make ::provideIncrementAndCheck static
@kostajh there still exists non-static data providers for tests related to the union query builder. However, I plan to remove that and importantly the tests that still rely on non-static data providers in T346044.
I've added T337159 as a subtask as this won't technically be resolved until those tests are fixed. They also are not trivial to fix (as the data providers use $this).