| Sgs | |
| May 22 2023, 4:47 PM |
| F37029197: empty_step_2.gif | |
| May 22 2023, 4:48 PM |
| F37029196: empty_step.gif | |
| May 22 2023, 4:47 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
The second and next steps are empty
What should have happened instead?:
All steps should display content
Software version (skip for WMF-hosted wikis like Wikipedia):
Beta.
Other information (browser name/version, screenshots, etc.):
Change 922159 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] MultiPaneDialog: remove attribute hidden instead of class
I think this is was caused when updating OOUI in core (921070) due to the change on how hiding StackLayout is handled in this change.
Since the GrowthExperiments relevant code was already a hack the fix is a low effort solution, probably brittle and could break again. Since the modal is gonna be migrated to Vue there's no much value on looking for a better ooui based solution. A selenium test could be ok.
Change 922159 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] MultiPaneDialog: remove attribute hidden instead of class
Change 922405 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.10] MultiPaneDialog: remove attribute hidden instead of class
Change 922405 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.10] MultiPaneDialog: remove attribute hidden instead of class
Mentioned in SAL (#wikimedia-operations) [2023-05-24T13:56:53Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:922405|MultiPaneDialog: remove attribute hidden instead of class (T337256)]], [[gerrit:920238|Add maint script to opt out active users from the new topic tool (T317375)]], [[gerrit:920731|Define $maintClass in maintenance script for compatibility (T317375)]], [[gerrit:920733|NewTopicOptOutActiveUsers: Skip bot users etc. (T317375)]]
Mentioned in SAL (#wikimedia-operations) [2023-05-24T13:58:27Z] <urbanecm@deploy1002> matmarex and urbanecm and sgimeno: Backport for [[gerrit:922405|MultiPaneDialog: remove attribute hidden instead of class (T337256)]], [[gerrit:920238|Add maint script to opt out active users from the new topic tool (T317375)]], [[gerrit:920731|Define $maintClass in maintenance script for compatibility (T317375)]], [[gerrit:920733|NewTopicOptOutActiveUsers: Skip bot users etc. (T317375)]] synced t
Mentioned in SAL (#wikimedia-operations) [2023-05-24T14:06:14Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:922405|MultiPaneDialog: remove attribute hidden instead of class (T337256)]], [[gerrit:920238|Add maint script to opt out active users from the new topic tool (T317375)]], [[gerrit:920731|Define $maintClass in maintenance script for compatibility (T317375)]], [[gerrit:920733|NewTopicOptOutActiveUsers: Skip bot users etc. (T317375)]] (duration: 09m 21s)