Page MenuHomePhabricator

"Edit" and "Edit source" links should have different titles
Closed, ResolvedPublic

Description

Now "Edit" and "Edit source" links have the same editsectionhint message: "Edit section: $1". It doesn't help people trying to figure out the difference between these two links. The "Edit source" link should probably have a title like "Edit section's source code: $1".

Event Timeline

ca-edit and ca-ve-edit also use the same title.

Change 936298 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/extensions/VisualEditor@master] Use different titles for "Edit" and "Edit source" links

https://gerrit.wikimedia.org/r/936298

Change 936378 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/core@master] Linker: Modify the tooltip if the page doesn't exist or is a local description, add a hook modifing tooltips

https://gerrit.wikimedia.org/r/936378

Change 936298 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use different titles for "Edit" and "Edit source" links (section headings)

https://gerrit.wikimedia.org/r/936298

matmarex edited projects, added Editing QA; removed Patch-For-Review.

@Dringsim Thanks for working on this! It looks to me like the issue is completely fixed by your first patch, and the second patch only has some tooltip/accesskey changes affecting the tabs at the top of the page, rather than section edit links. Am I understanding it right?

在T337653#9021972中,@matmarex写道:

@Dringsim Thanks for working on this! It looks to me like the issue is completely fixed by your first patch, and the second patch only has some tooltip/accesskey changes affecting the tabs at the top of the page, rather than section edit links. Am I understanding it right?

Yes.

Do the screenshots capture the desired behaviour?

Screenshot 2023-07-26 at 02.54.40.png (208×790 px, 29 KB)

Screenshot 2023-07-26 at 02.53.49.png (296×760 px, 37 KB)

Screenshot 2023-07-26 at 02.52.55.png (248×2 px, 126 KB)

{F37149922}

This file is not attached.

{F37149922}

This file is not attached.

Fixed. Sorry about that.

The merged patch is about the tooltips on section edit links, not the ones at the top of the page.

Change 936378 abandoned by 沈澄心:

[mediawiki/core@master] Linker: Modify the tooltip if the page doesn't exist or is a local description, add a hook modifing tooltips

Reason:

https://gerrit.wikimedia.org/r/936378

Change 936371 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/core@master] Skin: Allow links to have alternative tooltips

https://gerrit.wikimedia.org/r/936371

Change 942749 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/extensions/VisualEditor@master] Use different tooltips for ca-edit and ca-ve-edit links

https://gerrit.wikimedia.org/r/942749

Test wiki created on Patch demo by 沈澄心 using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/95dddb0dab/w

With this patch, the tabs at the top of the page that @EAkinloose pointed out will also have distinct tooltips.

Change 942749 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use different tooltips for ca-edit and ca-ve-edit links

https://gerrit.wikimedia.org/r/942749

Test wiki on Patch demo by 沈澄心 using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/95dddb0dab/w/