Error: Call to a member function getOutput() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	TheresNoTime
	May 30 2023, 7:47 PM

Description

Error

mwversion: 1.41.0-wmf.11
reqId: 3079b4b4-b417-4f17-923d-8f3d2ae2154c
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Error: Call to a member function getOutput() on null

exception.trace

from /srv/mediawiki/php-1.41.0-wmf.11/includes/linker/Linker.php(826)
#0 /srv/mediawiki/php-1.41.0-wmf.11/includes/linker/Linker.php(641): MediaWiki\Linker\Linker::makeThumbLink2(MediaWiki\Title\Title, ForeignDBFile, array, array, boolean, string, array)
#1 /srv/mediawiki/php-1.41.0-wmf.11/includes/page/ImagePage.php(525): MediaWiki\Linker\Linker::makeThumbLinkObj(MediaWiki\Title\Title, ForeignDBFile, string, string, string, array)
#2 /srv/mediawiki/php-1.41.0-wmf.11/includes/page/ImagePage.php(142): ImagePage->openShowImage()
#3 /srv/mediawiki/php-1.41.0-wmf.11/includes/actions/ViewAction.php(78): ImagePage->view()
#4 /srv/mediawiki/php-1.41.0-wmf.11/includes/MediaWiki.php(559): ViewAction->show()
#5 /srv/mediawiki/php-1.41.0-wmf.11/includes/MediaWiki.php(334): MediaWiki->performAction(ImagePage, MediaWiki\Title\Title)
#6 /srv/mediawiki/php-1.41.0-wmf.11/includes/MediaWiki.php(925): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.41.0-wmf.11/includes/MediaWiki.php(579): MediaWiki->main()
#8 /srv/mediawiki/php-1.41.0-wmf.11/index.php(50): MediaWiki->run()
#9 /srv/mediawiki/php-1.41.0-wmf.11/index.php(46): wfIndexMain()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Impact

Notes

Only seems to be affecting 1.41.0-wmf.11 wikis...

Details

Request URL: https://www.mediawiki.org/wiki/File:Initial_Assessment_of_New_Wikipedia_Portal%27s_Search_Box_Deployment.pdf

	Subject	Repo	Branch	Lines +/-
	linker: Check for null parser in Linker::makeThumbLink2	mediawiki/core	master	+1 -1
	linker: Check for null parser in Linker::makeThumbLink2	mediawiki/core	wmf/1.41.0-wmf.11	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• dduvall	T337525 1.41.0-wmf.11 deployment blockers
		Resolved	PRODUCTION ERROR	Umherirrender	T337794 Error: Call to a member function getOutput() on null

Event Timeline

TheresNoTime created this task.May 30 2023, 7:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2023, 7:47 PM

New code from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/919254 / 5265579, the variable $parser is documented as null, but not used as that.

TheresNoTime added a parent task: T337525: 1.41.0-wmf.11 deployment blockers.May 30 2023, 7:52 PM

Umherirrender claimed this task.May 30 2023, 7:53 PM

Change 924595 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] linker: Check for null parser in Linker::makeThumbLink2

https://gerrit.wikimedia.org/r/924595

gerritbot added a project: Patch-For-Review.May 30 2023, 7:56 PM

In this case happen only on multi-page files like pdf (with the PdfHandler extension) to generate the thumbs for next/prev link. In that case no linking is needed

Change 924595 merged by jenkins-bot:

[mediawiki/core@master] linker: Check for null parser in Linker::makeThumbLink2

https://gerrit.wikimedia.org/r/924595

Change 924570 had a related patch set uploaded (by Jforrester; author: Umherirrender):

[mediawiki/core@wmf/1.41.0-wmf.11] linker: Check for null parser in Linker::makeThumbLink2

https://gerrit.wikimedia.org/r/924570

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 30 2023, 9:00 PM

Change 924570 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.11] linker: Check for null parser in Linker::makeThumbLink2

https://gerrit.wikimedia.org/r/924570

Mentioned in SAL (#wikimedia-operations) [2023-05-30T21:48:45Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:924570|linker: Check for null parser in Linker::makeThumbLink2 (T337794)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-30T21:50:22Z] <samtar@deploy1002> jforrester and samtar: Backport for [[gerrit:924570|linker: Check for null parser in Linker::makeThumbLink2 (T337794)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-30T21:56:34Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:924570|linker: Check for null parser in Linker::makeThumbLink2 (T337794)]] (duration: 07m 48s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.11; 2023-05-30); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 30 2023, 10:00 PM

Many thanks @Umherirrender ✨

Maintenance_bot removed a project: Patch-For-Review.May 30 2023, 10:10 PM

Ugh 😞, thanks for stopping the bleeding @Umherirrender

Adding a module in the middle of Linker could be wrong as that function is used on many places in core. Not sure if other places needs the module as well.

It's a good point. I will audit other callers and see what needs doing.

Arlolra mentioned this in T337804: Thumb styling on the file description page and other callers of makeThumbLinkObj.May 30 2023, 11:54 PM

Krinkle added a project: Unstewarded-production-error.Feb 13 2024, 4:50 PM

Krinkle moved this task from Untriaged to May 2023 on the Wikimedia-production-error board.

Error: Call to a member function getOutput() on nullClosed, ResolvedPublicPRODUCTION ERRORActions