Page MenuHomePhabricator

Hide CheckUser and CheckUserLog CIDR calculator toolinks if user doesn't have rights to see those pages
Closed, ResolvedPublic

Description

The tool links shown on the CIDR calculator show a link to Special:CheckUser and Special:CheckUserLog. These links are always shown, even if the user does not have the rights to see these pages.

While the rights to see Special:CheckUser are currently correctly assumed to always be present (as the calculator is on Special:CheckUser), T268429 would make it possible for users without the checkuser right to use the CIDR calculator on a new special page.

Event Timeline

Dreamy_Jazz triaged this task as Medium priority.Jun 2 2023, 2:22 PM
Dreamy_Jazz created this task.

Change 926521 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Hide CheckUser and CheckUserLog CIDR toolinks if missing the right

https://gerrit.wikimedia.org/r/926521

Change 926521 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Hide CheckUser and CheckUserLog CIDR toolinks if missing the right

https://gerrit.wikimedia.org/r/926521

Dreamy_Jazz claimed this task.

With thanks to TNT for the quick merge, this is now resolved. Tests will be looked at.