Tabs: Update frameless tabs header to match design spec
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	CCiufo-WMF
	Jun 8 2023, 3:30 PM

Description

Background

It looks like our frameless tabs have 4px horizontal margin on each tab, so when there are 2 tabs next to each other they are separated with 8px (4px +4px).

But looking at the Figma spec, the margin between 2 tabs should total`4px` instead.

Acceptance Criteria

Remove the excess 4px margin between the tab items so that there is only 4px margin in total between 2 quiet tabs (frameless tabs)

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from v1.0.0 to v1.0.1	mediawiki/core	master	+606 -562
	Tabs: Update margin of frameless/quiet tabs	design/codex	main	+1 -1

Customize query in gerrit

Event Timeline

CCiufo-WMF created this task.Jun 8 2023, 3:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2023, 3:30 PM

CCiufo-WMF triaged this task as Low priority.Jun 8 2023, 3:30 PM

egardner raised the priority of this task from Low to Needs Triage.Oct 2 2023, 9:13 PM

egardner moved this task from Needs Refinement to Backlog on the Design-System-Team board.

CCiufo-WMF changed the subtype of this task from "Task" to "Bug Report".Oct 18 2023, 2:18 PM

CCiufo-WMF added a project: Codex.

CCiufo-WMF moved this task from Backlog to Up Next on the Design-System-Team board.

CCiufo-WMF set the point value for this task to 2.

CCiufo-WMF triaged this task as Low priority.Oct 27 2023, 6:35 PM

egardner moved this task from Up Next to DST-Sprint-11 (2023-10-30 to 2023-11-22) on the Design-System-Team board.Oct 30 2023, 7:22 PM

egardner edited projects, added Design-System-Team (DST-Sprint-11 (2023-10-30 to 2023-11-22)); removed Design-System-Team.

egardner changed the point value for this task from 2 to 3.

bmartinezcalvo updated the task description. (Show Details)Oct 31 2023, 10:06 AM

bmartinezcalvo updated the task description. (Show Details)Oct 31 2023, 10:08 AM

bmartinezcalvo updated the task description. (Show Details)Oct 31 2023, 10:14 AM

Change 971161 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] Tabs: Update margin of frameless/quiet tabs

https://gerrit.wikimedia.org/r/971161

gerritbot added a project: Patch-For-Review.Nov 2 2023, 12:54 PM

lwatson changed the task status from Open to In Progress.Nov 2 2023, 1:15 PM

lwatson claimed this task.

lwatson moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-11 (2023-10-30 to 2023-11-22)) board.

lwatson moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-11 (2023-10-30 to 2023-11-22)) board.Nov 2 2023, 1:18 PM

lwatson updated the task description. (Show Details)Nov 2 2023, 1:28 PM

lwatson updated the task description. (Show Details)

Catrope moved this task from Code Review to Design Sign-Off on the Design-System-Team (DST-Sprint-11 (2023-10-30 to 2023-11-22)) board.Nov 3 2023, 5:55 PM

Change 971161 merged by jenkins-bot:

[design/codex@main] Tabs: Update margin of frameless/quiet tabs

https://gerrit.wikimedia.org/r/971161

Maintenance_bot removed a project: Patch-For-Review.Nov 3 2023, 6:10 PM

Volker_E renamed this task from Tabs Component: Update frameless tabs header to match design spec to Tabs: Update frameless tabs header to match design spec.Nov 4 2023, 1:41 AM

Volker_E reassigned this task from lwatson to DTorsani-WMF.Nov 6 2023, 6:10 PM

Volker_E added a subscriber: lwatson.

DTorsani-WMF moved this task from Design Sign-Off to Pending Release on the Design-System-Team (DST-Sprint-11 (2023-10-30 to 2023-11-22)) board.Nov 6 2023, 9:01 PM

DTorsani-WMF reassigned this task from DTorsani-WMF to lwatson.Nov 6 2023, 9:05 PM

DTorsani-WMF subscribed.

Change 972687 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v1.0.0 to v1.0.1

https://gerrit.wikimedia.org/r/972687

gerritbot added a project: Patch-For-Review.Nov 8 2023, 6:59 AM

Change 972687 merged by jenkins-bot: