Page MenuHomePhabricator

Migrate WikiLambda extension to Vue 3
Closed, ResolvedPublic

Description

Event Timeline

Jdforrester-WMF subscribed.

Setting priority; we hope to get this done in the next few months' time.

egardner raised the priority of this task from Medium to Needs Triage.Oct 2 2023, 9:13 PM
egardner moved this task from Needs Refinement to Backlog on the Design-System-Team board.

Change 968786 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/extensions/WikiLambda@master] Disable all Vue 3 compat, including whitespace handling

https://gerrit.wikimedia.org/r/968786

WikiLambda already had { MODE: 3 } set globally, which is most of what was needed. The remaining steps are:

  • Setting whitespace handling to 'condense' to match Vue 3; the attached patch does this. This typically doesn't cause problems, but it can change behavior in some rare circumstances.
  • Testing WikiLambda with this unmerged core change, to verify that removing the Vue 3 compat build would not break anything in WikiLambda

Once those two things are done, this task can be closed.

Change 968787 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/extensions/WikiLambda@master] Prepare Vue setup code for migration away from compat build

https://gerrit.wikimedia.org/r/968787

Change 968786 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Disable all Vue 3 compat, including whitespace handling

https://gerrit.wikimedia.org/r/968786

Change 968787 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Prepare Vue setup code for migration away from compat build

https://gerrit.wikimedia.org/r/968787

WikiLambda already had { MODE: 3 } set globally, which is most of what was needed. The remaining steps are:

  • Setting whitespace handling to 'condense' to match Vue 3; the attached patch does this. This typically doesn't cause problems, but it can change behavior in some rare circumstances.

Merged. Thank you!

  • Testing WikiLambda with this unmerged core change, to verify that removing the Vue 3 compat build would not break anything in WikiLambda

Have just done a quick test; everything seems fine. Buttons, inputs, dialogs, menus, look-ups, icons all appear as expected, and all of the Vue 2->3 migration warning spam is gone.

Once those two things are done, this task can be closed.

Thank you!

Great, thank you! WikiLambda should be all set for the migration then