Page MenuHomePhabricator
Create Task
Maniphest T340570

Codex settings icon not working
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

When using .cdx-mixin-css-icon( @cdx-icon-settings, @param-is-button-icon: true ); no settings icon is rendering

Screenshot 2023-06-27 at 12.00.36 PM.png (118×644 px, 13 KB)

The icon is defined in resources/lib/codex-icons/codex-icon-paths.less but presumably is not correct?

Details

SubjectRepoBranchLines +/-
Update Codex from v0.13.0 to v0.14.0mediawiki/coremaster+526 -522
Icon: Make <use> work in CSS-only iconsdesign/codexmain+128 -10
Icon, docs: Use "code" instead of "tag" in CSS-only icon demodesign/codexmain+7 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jun 27 2023, 7:01 PM
Catrope subscribed.Jun 28 2023, 4:30 PM

It looks like there's an escaping error that affects all icons that do <use xlink:href="#foo">. The affected icons are settings, code and tableMergeCells.

gerritbot added a comment.Jun 28 2023, 4:41 PM

Change 933979 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] Icon, docs: Use "code" instead of "tag" in CSS-only icon demo

https://gerrit.wikimedia.org/r/933979

gerritbot added a project: Patch-For-Review.Jun 28 2023, 4:41 PM
gerritbot added a comment.Jun 28 2023, 4:56 PM

Change 933983 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] Icon: Make <use> work in CSS-only icons

https://gerrit.wikimedia.org/r/933983

Catrope edited projects, added Design-System-Team (Design-Systems-Sprint-2); removed Design-System-Team.Jun 28 2023, 4:56 PM
Catrope moved this task from Committed to Code Review on the Design-System-Team (Design-Systems-Sprint-2) board.
Catrope set the point value for this task to 2.
Catrope claimed this task.Jun 28 2023, 4:59 PM
gerritbot added a comment.Jun 28 2023, 5:37 PM

Change 933979 merged by jenkins-bot:

[design/codex@main] Icon, docs: Use "code" instead of "tag" in CSS-only icon demo

https://gerrit.wikimedia.org/r/933979

gerritbot added a comment.Jun 29 2023, 1:44 PM

Change 933983 merged by jenkins-bot:

[design/codex@main] Icon: Make <use> work in CSS-only icons

https://gerrit.wikimedia.org/r/933983

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2023, 2:10 PM
Catrope moved this task from Code Review to Pending Release on the Design-System-Team (Design-Systems-Sprint-2) board.Jun 29 2023, 5:20 PM
gerritbot added a comment.Jul 5 2023, 6:37 PM

Change 935794 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.13.0 to v0.14.0

https://gerrit.wikimedia.org/r/935794

gerritbot added a project: Patch-For-Review.Jul 5 2023, 6:37 PM
PatchDemoBot added a comment.Jul 5 2023, 7:11 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/64dc3126c0/w

gerritbot added a comment.Jul 5 2023, 7:32 PM

Change 935794 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.13.0 to v0.14.0

https://gerrit.wikimedia.org/r/935794

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 5 2023, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 5 2023, 8:10 PM
Catrope closed this task as Resolved.Jul 6 2023, 7:38 PM

This should be fixed with the new Codex release (0.14.0), please reopen if it's still broken somehow.

PatchDemoBot added a comment.Aug 16 2023, 6:45 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/64dc3126c0/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits