Page MenuHomePhabricator
Create Task
Maniphest T340929

IP range block log not showing when the target is prefixed with User:
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
"No matching items in log."

What should have happened instead?:
The block log is shown.

Other information (browser name/version, screenshots, etc.):
The block log correctly appears if you

Details

SubjectRepoBranchLines +/-
SpecialLog: Fix issues related to IP usersmediawiki/corewmf/1.41.0-wmf.15+6 -3
SpecialLog: Fix issues related to IP usersmediawiki/coremaster+6 -3
Customize query in gerrit

Related Objects

Event Timeline

Nardog created this task.Jul 2 2023, 7:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2023, 7:59 PM
Nardog updated the task description. (Show Details)Jul 2 2023, 8:05 PM
Nardog mentioned this in T266480: Extension should not create LogPager, use LogEventsList::showLogExtract or custom select query instead.Jul 2 2023, 8:19 PM
gerritbot added a comment.Jul 2 2023, 8:43 PM

Change 934458 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SpecialLog: Fix logs of IP user target

https://gerrit.wikimedia.org/r/934458

gerritbot added a project: Patch-For-Review.Jul 2 2023, 8:43 PM
Nardog edited projects, added MediaWiki-Special-pages; removed MediaWiki-Blocks.Jul 2 2023, 8:50 PM
Nardog added a subscriber: Func.Jul 2 2023, 8:52 PM

@Func Thanks for the patch. One thing that's not clear to me is why "User:" is in the Target textbox if it's not in the URL query, and vice versa. Is this intentional?

Func added a comment.EditedJul 2 2023, 8:54 PM
In T340929#8984231, @Nardog wrote:

@Func Thanks for the patch. One thing that's not clear to me is why "User:" is in the Target textbox if it's not in the URL query, and vice versa. Is this intentional?

Not intentional, will be fixed by this patch and always prefixed with User:.

Johannnes89 subscribed.Jul 3 2023, 9:24 AM

@Func there seems to be bug with logs of IPs which is probably related:

Visit e.g. meta:Special:Contributions/92.4.182.16 -> click „logs“ -> meta:Special:Log/92.4.182.16 opens and claims „92.4.182.16 isn't a valid username“
If I enter meta:Special:Log/User:92.4.182.16 it still says „... isn't a valid username“.

Is that covered by your patch or should I open a new bug report?

Func added a comment.Jul 3 2023, 9:54 AM
In T340929#8984726, @Johannnes89 wrote:

Is that covered by your patch or should I open a new bug report?

Thanks, I modified the patch to cover that. Any issues related to Special:Log is welcome to post on this bug report.

Dreamy_Jazz triaged this task as Medium priority.Jul 3 2023, 9:55 AM
gerritbot added a comment.Jul 3 2023, 11:21 AM

Change 934458 merged by jenkins-bot:

[mediawiki/core@master] SpecialLog: Fix issues related to IP users

https://gerrit.wikimedia.org/r/934458

Maintenance_bot removed a project: Patch-For-Review.Jul 3 2023, 11:30 AM
gerritbot added a comment.Jul 3 2023, 11:37 AM

Change 934624 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@wmf/1.41.0-wmf.15] SpecialLog: Fix issues related to IP users

https://gerrit.wikimedia.org/r/934624

gerritbot added a project: Patch-For-Review.Jul 3 2023, 11:37 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 3 2023, 12:00 PM
gerritbot added a comment.Jul 3 2023, 1:16 PM

Change 934624 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.15] SpecialLog: Fix issues related to IP users

https://gerrit.wikimedia.org/r/934624

Stashbot mentioned this in T338042: Special:Log should show error when the input is invalid.Jul 3 2023, 1:19 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-03T13:19:03Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:934624|SpecialLog: Fix issues related to IP users (T338042 T340929)]]

Stashbot added a comment.Jul 3 2023, 1:20 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-03T13:20:25Z] <urbanecm@deploy1002> func and urbanecm: Backport for [[gerrit:934624|SpecialLog: Fix issues related to IP users (T338042 T340929)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Jul 3 2023, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-03T13:27:35Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:934624|SpecialLog: Fix issues related to IP users (T338042 T340929)]] (duration: 08m 32s)

Maintenance_bot removed a project: Patch-For-Review.Jul 3 2023, 1:29 PM
Func closed this task as Resolved.Jul 3 2023, 1:33 PM
Func claimed this task.
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 3 2023, 2:00 PM
matmarex subscribed.Jul 4 2023, 12:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL