Page MenuHomePhabricator
Create Task
Maniphest T341278

Fix how settings work with global preference (limited width, font size, night mode)
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Jul 6 2023, 6:43 PM
Tags
Referenced Files
F55503744: 2024-06-20_13-23-22.mp4.gif
Thu, Jun 20, 10:04 PM
F55500910: Screenshot 2024-06-20 at 10.05.41 AM.png
Thu, Jun 20, 6:06 PM
F55478656: 2024-06-19_14-48-50.mp4.gif
Wed, Jun 19, 10:19 PM
Subscribers
Aklapper
GMikesell-WMF
Jdlrobson
Johannnes89
KSarabia-WMF
LucasWerkmeister
ovasileva
View All 9 Subscribers

Description

Caused by T323076
Steps to replicate the issue (include links if applicable):

beta-cluster

Screenshot 2024-06-20 at 10.05.41 AM.png (612×1 px, 95 KB)

  1. Production
  2. Visit https://meta.wikimedia.org/wiki/Special:GlobalPreferences and check the box for "Enable limited width mode" to mark it as a global preference.
  3. Visit https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering and confirm there is no local override
  4. Visit https://en.wikipedia.org/wiki/Main_Page with limited width enabled. Click button in bottom right to change to full width
  5. Refresh page

What happens?:

  • Limited width is still on

What should have happened instead?:

  • Page should be full width

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Looking at the API, a warning message is present.

This should also be applied to font size and night theme.

QA Results - Beta

ACStatusDetails
1✅T341278#9911998

Details

SubjectRepoBranchLines +/-
Do not show preferences, if night mode or appearance menu is disabledmediawiki/skins/Vectormaster+8 -2
Client preferences should user new user preference APImediawiki/skins/Vectormaster+3 -2
Make all frontend stored preferences globalmediawiki/skins/Vectormaster+85 -43
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ovasileva added a comment.Sep 14 2023, 5:23 PM
In T341278#9164482, @Jdlrobson wrote:

@ovasileva with the fix to T345664 we could make the limited width a device specific preference. The proper fix to this issue is T323076 so we'd rather not make a change to Vector that adds technical debt.

Moving this to the next sprint to allow for decisions to be made on T345664: How should client preferences work for logged in users?

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6).Sep 14 2023, 5:24 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).Oct 9 2023, 12:28 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.Oct 12 2023, 5:48 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2).Oct 23 2023, 3:06 PM
ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3).Nov 2 2023, 12:10 PM
ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.
Jdlrobson moved this task from Current Fiscal Year to FY2023-24 Q2 Sprint 5 on the Web-Team-Backlog board.Nov 6 2023, 7:52 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q2 Sprint 5); removed Web-Team-Backlog.
Jdlrobson moved this task from Incoming to Doing on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 7:03 PM
Jdlrobson moved this task from Doing to Incoming on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 7:06 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q2 Sprint 5).Dec 4 2023, 8:46 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 4 2024, 12:21 AM
ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 2); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 1).Jan 4 2024, 9:42 AM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 3); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 2).Jan 29 2024, 7:02 PM
Jdlrobson renamed this task from Limited width preference doesn't work when set as a global preference to Review how settings work with global preference (limited width, font size, night mode).Feb 1 2024, 7:21 PM
Jdlrobson added a project: FY2023-24-WE 2.1 Typography and palette customizations.
Jdlrobson moved this task from FY2023-24 Q3 Sprint 3 to FY2023-24 Q3 Sprint 4 on the Web-Team-Backlog board.Feb 8 2024, 12:43 AM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 4); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 3).
Jdlrobson moved this task from Backlog to General on the FY2023-24-WE 2.1 Typography and palette customizations board.Feb 9 2024, 6:31 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.Feb 23 2024, 8:00 PM
ovasileva moved this task from Ready for Development to Incoming on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.Feb 26 2024, 12:05 PM
ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 4).Feb 26 2024, 2:27 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.Feb 29 2024, 7:28 PM
Jdlrobson moved this task from Ready for Development to Incoming on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.Mar 12 2024, 5:00 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).Mar 18 2024, 7:00 PM
Jdlrobson added a parent task: T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work).Apr 1 2024, 9:49 PM
Jdlrobson added a project: patch-welcome.EditedMay 16 2024, 2:51 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson merged a task: T365153: Allow customizing Vector 2022 appearance settings via global greferences.
Jdlrobson added a subscriber: taavi.

We were waiting on T323076 for this one. I followed up on the ticket :)

taavi merged a task: T365373: Global settings for the Appearance menu.May 20 2024, 4:55 PM
taavi added subscribers: sgrabarczuk, Johannnes89.
ovasileva raised the priority of this task from Medium to High.May 22 2024, 7:13 AM
ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 5); removed Web-Team-Backlog.
ovasileva moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.May 23 2024, 9:22 AM
Jdlrobson edited projects, added Desktop Improvements (Vector 2022) (Tracking); removed Desktop Improvements (Vector 2022).May 28 2024, 8:59 PM
Jdlrobson moved this task from Ready for Development to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.Thu, May 30, 6:07 PM
Jdlrobson changed the task status from Open to Stalled.Fri, May 31, 8:07 PM
Jdlrobson moved this task from Ready for estimation to Needs analysis on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.

Stalled on T323076

Jdlrobson claimed this task.Tue, Jun 4, 9:25 PM
Jdlrobson added a subscriber: ovasileva.
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 5).Fri, Jun 7, 10:14 PM
Jdlrobson renamed this task from Review how settings work with global preference (limited width, font size, night mode) to Fix how settings work with global preference (limited width, font size, night mode).Thu, Jun 13, 1:01 AM
Jdlrobson merged a task: T367238: Make Vector 2022 font size available as global preference.
Jdlrobson added a subscriber: LucasWerkmeister.
gerritbot added a comment.Thu, Jun 13, 3:55 PM

Change #1038452 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Make all frontend stored preferences global

https://gerrit.wikimedia.org/r/1038452

gerritbot added a project: Patch-For-Review.Thu, Jun 13, 3:55 PM
Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 13, 3:55 PM

This is moving along nicely. I'm hoping we'll be able to wrap the work up next week.

Jdlrobson updated the task description. (Show Details)Fri, Jun 14, 6:30 PM
Jdlrobson moved this task from Ready for estimation to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Mon, Jun 17, 5:57 PM
Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.
Jdlrobson changed the task status from Stalled to Open.Mon, Jun 17, 6:59 PM
Jdlrobson removed Jdlrobson as the assignee of this task.
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

If a reviewer needs help setting up GlobalPreferences I can help (if you use docker)

ovasileva assigned this task to KSarabia-WMF.Tue, Jun 18, 4:16 PM
KSarabia-WMF reassigned this task from KSarabia-WMF to GMikesell-WMF.Tue, Jun 18, 5:43 PM
KSarabia-WMF moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.
KSarabia-WMF subscribed.
gerritbot added a comment.Tue, Jun 18, 6:08 PM

Change #1038452 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Make all frontend stored preferences global

https://gerrit.wikimedia.org/r/1038452

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 18, 6:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Tue, Jun 18, 7:00 PM
Jdlrobson claimed this task.Tue, Jun 18, 8:08 PM
Jdlrobson moved this task from QA to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.
Jdlrobson added a subscriber: GMikesell-WMF.

Not working on beta cluster.. looking..

gerritbot added a comment.Tue, Jun 18, 8:26 PM

Change #1047172 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Client preferences should user new user preference API

https://gerrit.wikimedia.org/r/1047172

gerritbot added a project: Patch-For-Review.Tue, Jun 18, 8:26 PM
gerritbot added a comment.Tue, Jun 18, 9:15 PM

Change #1047172 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Client preferences should user new user preference API

https://gerrit.wikimedia.org/r/1047172

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 18, 9:31 PM
Jdlrobson reassigned this task from Jdlrobson to GMikesell-WMF.Tue, Jun 18, 9:54 PM
Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.
gerritbot added a comment.Tue, Jun 18, 10:12 PM

Change #1047186 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Do not show preferences, if night mode or appearance menu is disabled

https://gerrit.wikimedia.org/r/1047186

gerritbot added a project: Patch-For-Review.Tue, Jun 18, 10:12 PM
gerritbot added a comment.Tue, Jun 18, 10:43 PM

Change #1047186 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Do not show preferences, if night mode or appearance menu is disabled

https://gerrit.wikimedia.org/r/1047186

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 18, 11:30 PM
GMikesell-WMF added a comment.Wed, Jun 19, 10:19 PM

@Jdlrobson As seen in the gif when it comes to the last link https://ca.wikipedia.beta.wmflabs.org in Step 4, I did not go to "wide" but "Standard"

Test Result - Beta

Status: ❌ FAIL
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Steps

  1. Visit https://ca.wikipedia.beta.wmflabs.org/wiki/Especial:GlobalPreferences#mw-prefsection-rendering and set "Enable limited width mode" as a global preference.
  2. Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Preferences#mw-prefsection-rendering and confirm there is no local override
  3. Visit https://en.wikipedia.beta.wmflabs.org with limited width enabled. Click button in bottom right to change to full width
  4. Visit https://ca.wikipedia.beta.wmflabs.org

❌AC1: Page should be full width

2024-06-19_14-48-50.mp4.gif (672×1 px, 1 MB)

GMikesell-WMF updated the task description. (Show Details)Wed, Jun 19, 10:19 PM
Jdlrobson updated the task description. (Show Details)Thu, Jun 20, 6:06 PM

Hi @GMikesell-WMF - you need to make sure "Set to global is checked". I've updated the QA steps to make this clearer.

GMikesell-WMF added a comment.Thu, Jun 20, 10:04 PM

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Steps

  1. Visit https://ca.wikipedia.beta.wmflabs.org/wiki/Especial:GlobalPreferences#mw-prefsection-rendering and set "Enable limited width mode" as a global preference by checking the checkbox to the far left and clicking save at the bottom of the page
  2. Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Preferences#mw-prefsection-rendering and confirm there is no local override
  3. Visit https://en.wikipedia.beta.wmflabs.org with limited width enabled. Click button in bottom right to change to full width
  4. Visit https://ca.wikipedia.beta.wmflabs.org ✅ AC1: Page should be full width

2024-06-20_13-23-22.mp4.gif (674×1 px, 3 MB)

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Thu, Jun 20, 10:04 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.
Jdlrobson assigned this task to ovasileva.Fri, Jun 21, 1:25 AM
ovasileva closed this task as Resolved.Mon, Jun 24, 10:20 AM
ovasileva added a project: User-notice.

For tech news: "All options in the Appearance menu (Text for font size, Width for page width, and Color for dark/light mode) can now be set as global preferences."

Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Thu, Jun 27, 11:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits