Page MenuHomePhabricator

Civi Forget Me button error
Closed, ResolvedPublic2 Estimated Story Points

Description

Pressing Forget Me for cid=31415709 yields this error today:

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '))' at line 4

FM button 2023-07-11 at 5.49.48 PM.png (1×1 px, 177 KB)

Event Timeline

Change 937193 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fix early return on no-records found

https://gerrit.wikimedia.org/r/937193

This was caused by an update made last month but does not affect all donors as it only arises when the contact has donations but not contribution_tracking entries

Change 937201 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Convert PaymentsFraud access to use apiv4

https://gerrit.wikimedia.org/r/937201

I've put up a patch for this & it is on staging now. I also put up a follow on code improvement patch to make the code hurt our brains less in the future

Change 937193 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fix early return on no-records found

https://gerrit.wikimedia.org/r/937193

Eileenmcnaughton set the point value for this task to 2.
Eileenmcnaughton set Final Story Points to 2.

@MBeat33 We just pushed out a fix

Awesome, many thanks @Eileenmcnaughton

The fix worked for cid=31415709

Change 937201 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Convert PaymentsFraud access to use apiv4

https://gerrit.wikimedia.org/r/937201

@MBeat33 I just deployed one further patch on this - which just improves the code. It should still work but letting you know so you don't feel gaslit if anything unexpected happens

Thanks for the extra improvement + the headsup