Page MenuHomePhabricator
Create Task
Maniphest T341681

Clicking on an already-focused focusable node deactivates the surface (or removes the selection on surface where this is possible)
Closed, ResolvedPublic
Actions

Description

Clicking on a focusable node (e.g. image, template) a second time tries to remove focus from it.

In VE article editing this results in the surface being deactivated and the selection going grey.

In DiscussonTools this results in the selection be removed.

This is also makes it impossible to drag and drop and focusable node while it is already focused.

Expected

Clicking a second time should do nothing (unless done quickly as part of a double click).

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (c1420586c)mediawiki/extensions/VisualEditormaster+1 -1
Handle clicking on a focusable node that is already focusedVisualEditor/VisualEditormaster+10 -3
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 12 2023, 11:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2023, 11:32 AM
Esanders added a project: Regression.Jul 12 2023, 11:33 AM
Esanders added a comment.Jul 12 2023, 11:37 AM

Bisect blames https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/651722

Esanders updated the task description. (Show Details)Jul 12 2023, 11:42 AM
gerritbot added a comment.Jul 14 2023, 2:18 PM

Change 938248 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Handle clicking on a focusable node that is already focused

https://gerrit.wikimedia.org/r/938248

gerritbot added a project: Patch-For-Review.Jul 14 2023, 2:18 PM
DLynch assigned this task to Esanders.Jul 29 2023, 6:34 PM
DLynch added a project: Editing QA.
gerritbot added a comment.Jul 29 2023, 6:36 PM

Change 938248 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Handle clicking on a focusable node that is already focused

https://gerrit.wikimedia.org/r/938248

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2023, 7:10 PM
matmarex added a project: Editing-team (Kanban Board).Jul 30 2023, 8:10 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jul 31 2023, 11:05 AM

Change 943525 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c1420586c)

https://gerrit.wikimedia.org/r/943525

gerritbot added a project: Patch-For-Review.Jul 31 2023, 11:05 AM
gerritbot added a comment.Jul 31 2023, 11:25 AM

Change 943525 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c1420586c)

https://gerrit.wikimedia.org/r/943525

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 11:30 AM
EAkinloose edited projects, added Verified; removed Editing QA.Jul 31 2023, 10:11 PM
EAkinloose subscribed.

This works as expected. With double click for focusable nodes working as expected.

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 31 2023, 10:12 PM
ppelberg closed this task as Resolved.Aug 17 2023, 10:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL