Page MenuHomePhabricator

SX Pick a sentence step: Contents should be scrolled to the selected translation segment when returning from mobile editor
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • 1. Visit Section Translation application
  • 2. Select a section to translate
  • 3. Move to "Pick a sentence" step
  • 4. Select a sentence that is not inside the initial viewport and click to edit the machine translation.
  • 5. Apply the edited translation

What happens?:
The "Pick a sentence" step is loaded with the scroll height being 0 and the selected translation unit (which is the next one from the just translated sentence) is not visible inside the viewport.

What should have happened instead?:
Contents should be scrolled to the selected translation segment, so that the selected segment is visible when the step is loaded.

Other information (browser name/version, screenshots, etc.):
Screencast from el production wiki:

Event Timeline

ngkountas triaged this task as Medium priority.

Apparently, this issue is not a regression and it never worked until now!

Change 937459 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Scroll to selected segment when returning from mobile editor

https://gerrit.wikimedia.org/r/937459

Nikerabbit changed the task status from Open to In Progress.Jul 31 2023, 11:46 AM

Change 937459 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Scroll to selected segment when returning from mobile editor

https://gerrit.wikimedia.org/r/937459

Change 952858 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230828

https://gerrit.wikimedia.org/r/952858

Change 954671 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230904

https://gerrit.wikimedia.org/r/954671

Change 954671 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230904

https://gerrit.wikimedia.org/r/954671

Change 952858 abandoned by Nik Gkountas:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230828

Reason:

abandoning since we have already merged a newer build (I7d69dfb6c215a7769e74483bfa25d0b0ce2520a2)

https://gerrit.wikimedia.org/r/952858

This issue is now fixed in production. The contents are properly scrolled to the selected translation segment.

Screencast from greek (el) production wiki: