Page MenuHomePhabricator

Section highlight moves out of the viewport when applying or skipping a proposed translation
Closed, ResolvedPublic

Description

When applying the proposed translation or skipping it for a sentence, the highlight moves to the next sentence. However, the viewport is not scrolling when the highlight moves out of the viewport:

This is a regression, where the expected behaviour is for the contents to scroll so that the newly highlighted sentence is visible n the viewport. A similar fix was completed in T341685.

Event Timeline

Wangombe changed the task status from Open to In Progress.Sep 18 2023, 7:22 AM
Wangombe claimed this task.

Change 958933 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] SX: Highlight section when applying or skipping translation

https://gerrit.wikimedia.org/r/958933

Change 960060 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Scroll to selected segment on selected translation unit update

https://gerrit.wikimedia.org/r/960060

Change 958933 abandoned by Wangombe:

[mediawiki/extensions/ContentTranslation@master] SX: Highlight section when applying or skipping translation

Reason:

See I989633dfdcfe9df73a4611e0c4e0379366e6bf53

https://gerrit.wikimedia.org/r/958933

Change 960060 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Scroll to selected segment on selected translation unit update

https://gerrit.wikimedia.org/r/960060

Change 962059 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230929

https://gerrit.wikimedia.org/r/962059

Change 962059 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230929

https://gerrit.wikimedia.org/r/962059

Test status: QA PASS

the scrolling occurs when the highlighted area goes past the view point