Use Html::* instead of Xml::* in FlaggedRevs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Jul 13 2023, 10:15 AM

Description

FlaggedRevs uses a bunch of Xml methods for building HTML; as far as I can tell, the only reason for that seems to be that the code is quite old, possibly predating the Html class altogether, and was never migrated to Html. Since the use of Xml methods caused a CI issue and train blocker in T341566, we should move to the Html class instead.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Replace last use of Xml class with XmlSelect	mediawiki/extensions/FlaggedRevs	master	+14 -8
Replace most of the more trivial Xml::… form builder methods	mediawiki/extensions/FlaggedRevs	master	+61 -50
Replace many trivial Xml::… with Html::… methods	mediawiki/extensions/FlaggedRevs	master	+32 -39

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T341775 Discourage, deprecate and stop using Xml methods for building HTML markup
		Resolved		thiemowmde	T341776 Use Html::* instead of Xml::* in FlaggedRevs

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 13 2023, 10:15 AM

Lucas_Werkmeister_WMDE mentioned this in T341566: With $wgUseMediaWikiUIEverywhere = true, Xml::input() with class attribute causes warning or TypeError: htmlspecialchars() expects parameter 1 to be string, array given.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Novem_Linguae subscribed.Jul 13 2023, 10:18 AM

matmarex subscribed.Jul 13 2023, 12:31 PM

Jdforrester-WMF subscribed.Jul 13 2023, 1:04 PM

Change #1021859 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FlaggedRevs@master] Replace many trivial Xml::… with Html::… methods

https://gerrit.wikimedia.org/r/1021859

gerritbot added a project: Patch-For-Review.Apr 19 2024, 8:09 AM

Change #1021869 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FlaggedRevs@master] Replace most of the more trivial Xml::… form builder methods

https://gerrit.wikimedia.org/r/1021869

Change #1021859 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace many trivial Xml::… with Html::… methods

https://gerrit.wikimedia.org/r/1021859

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 19 2024, 10:00 AM

Change #1028496 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/UserGroups@master] Replace most of the more trivial Xml::… form builder methods

https://gerrit.wikimedia.org/r/1028496

Change #1028755 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/MassEditRegex@master] Replace most of the more trivial Xml::… form builder methods

https://gerrit.wikimedia.org/r/1028755

Change #1021869 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace most of the more trivial Xml::… form builder methods

https://gerrit.wikimedia.org/r/1021869

matmarex removed a project: Patch-For-Review.May 10 2024, 6:25 PM

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.5; 2024-05-14); removed MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).May 10 2024, 7:00 PM

This is almost completely done; there's only one hit left per https://codesearch.wmcloud.org/search/?q=Xml%3A%3A&files=&excludeFiles=&repos=Extension%3AFlaggedRevs — a call to Xml::listDropdown() in includes/frontend/specialpages/actions/Stabilization.php.