Page MenuHomePhabricator

Use Html::* instead of Xml::* in FlaggedRevs
Open, Needs TriagePublic

Description

FlaggedRevs uses a bunch of Xml methods for building HTML; as far as I can tell, the only reason for that seems to be that the code is quite old, possibly predating the Html class altogether, and was never migrated to Html. Since the use of Xml methods caused a CI issue and train blocker in T341566, we should move to the Html class instead.

Event Timeline

Change #1021859 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FlaggedRevs@master] Replace many trivial Xml::… with Html::… methods

https://gerrit.wikimedia.org/r/1021859

Change #1021869 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FlaggedRevs@master] Replace most of the more trivial Xml::… form builder methods

https://gerrit.wikimedia.org/r/1021869

Change #1021859 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace many trivial Xml::… with Html::… methods

https://gerrit.wikimedia.org/r/1021859

Change #1028496 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/UserGroups@master] Replace most of the more trivial Xml::… form builder methods

https://gerrit.wikimedia.org/r/1028496

Change #1028755 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/MassEditRegex@master] Replace most of the more trivial Xml::… form builder methods

https://gerrit.wikimedia.org/r/1028755

Change #1021869 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace most of the more trivial Xml::… form builder methods

https://gerrit.wikimedia.org/r/1021869