Page MenuHomePhabricator

Special:Preferences tab/section navigation hints are missing
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Visit Special:Preferences
  • Use the tab key to navigate to the first preference tab (desktop) or section (mobile)

What happens?:

No navigation hint is displayed before tabbing into the tabs (desktop) or sections (mobile)

What should have happened instead?:

A hint message should be displayed before tabbing into the first tab (desktop) or section (mobile)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Code changed in 4aa9c929102f4e162c242d647b74523f85363b22 mistakenly rewrote tabIndex to sectionIndex
Code added in 4aa9c929102f4e162c242d647b74523f85363b22, but didn't add the message to json file

Event Timeline

Change 952494 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/core@master] Special:Preferences fix broken navigation hints

https://gerrit.wikimedia.org/r/952494

jsn.sherman renamed this task from Message prefs-sections-navigation-hint is missing to Special:Preferences tab/section navigation hints are missing.Aug 25 2023, 7:49 PM
jsn.sherman changed the task status from Open to In Progress.
jsn.sherman triaged this task as High priority.
jsn.sherman updated the task description. (Show Details)

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/68d9f5b10c/w

Change 952494 merged by jenkins-bot:

[mediawiki/core@master] Special:Preferences fix broken navigation hints

https://gerrit.wikimedia.org/r/952494

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/68d9f5b10c/w/