Page MenuHomePhabricator

WikiEditor: Replace $.client.profile().name === 'msie' with feature detection
Closed, DuplicatePublic

Description

Sniffing is unpleasant, and the needed stuff may or may not be relevant on future versions of IE.


Version: unspecified
Severity: normal

Details

Reference
bz32184
TitleReferenceAuthorSource BranchDest Branch
Fix preceding_simblings() typorepos/mwbot-rs/mwbot!54epicpuppermainmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:59 PM
bzimport added a project: WikiEditor.
bzimport set Reference to bz32184.
bzimport added a subscriber: Unknown Object (MLST).

(This seems to be mostly used in checking whether we need to save/restore the scroll & selection state. Since an IE-specific interface is being used there, it may make more sense to base the check on that.)

Comment 1 belonged on bug 32185. :) The .test() is being used as a blacklist for known-broken versions if I'm reading correctly, so this can be lower-priority.

Not ideal, but allows newer versions to work.

Several things are blacklisted without a version number, which may or may not actually belong there forever:

			'blackberry': false,
			'ipod': false,
			'iphone': false

"Lowest", reflecting the lack of activity in more than two years and the apparent lack of current plans.

The problem with getting away from this is that what don't really have the information anymore as to WHY this stuff is on the blacklist.

I have at least made the full false into something that is versioned, exposing the wikieditor functionality starting iOS6 in this changeset: https://gerrit.wikimedia.org/r/#/c/132603/

The other profile check, is for IE problems, and that has to do with DOM changes removing focus from focusable elements. I'm not sure if that bug still exists in more recent versions.

IE11 does maintain the selection when a dialog is opened and closed, but IE11, Firefox 31, and Chromium 36 cannot make any use of that because the textbox is not focused after the dialog is closed. The scrollTop thing also seems to be a non-issue on IE11.