Page MenuHomePhabricator

Screenreader support: When focusing expandable panes, the pills are read out but no context is given
Closed, ResolvedPublic

Description

There are two places where the interface can be collapsed into wide button that then also can be used to unfold again. The button also includes previews on what's folded in from the search fields represented by pills. The pills even can be focused with the keyboard to remove them and change the search results.

Expandable Pills.png (64×700 px, 10 KB)

There are several issues here that could be addressed:

  • When a collapsed pane is focused everything on there is written out as a long connected text. There's no more context given on the different elements on there. Or even a distinction.
  • You can tab though the list of pills but again the context is not quite clear, especially that you can remove them.

Current improvements:

Event Timeline

Change 954603 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Move label creation to ExpandablePane and make label explicit

https://gerrit.wikimedia.org/r/954603

Change 954678 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Set sort order preview tag disabled

https://gerrit.wikimedia.org/r/954678

Change 954683 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] Make it possible to delete standard sort order in preview

https://gerrit.wikimedia.org/r/954683

Change 954678 abandoned by WMDE-Fisch:

[mediawiki/extensions/AdvancedSearch@master] Set sort order preview tag disabled

Reason:

Going for I7f964fa372347a45d473f7af7bd543dfb1aeefed instead

https://gerrit.wikimedia.org/r/954678

Change 954696 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Add seperator to search preview tags

https://gerrit.wikimedia.org/r/954696

Change 954710 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] :Convert search preview tags into a list with a description

https://gerrit.wikimedia.org/r/954710

Change 954683 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Make it possible to delete standard sort order in preview

https://gerrit.wikimedia.org/r/954683

Change 954913 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] Drop pointless greater/smaller-than symbol messages

https://gerrit.wikimedia.org/r/954913

Change 954914 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] Use proper word and comma separator messages in SearchPreview

https://gerrit.wikimedia.org/r/954914

Change 954913 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Drop pointless greater/smaller-than symbol messages

https://gerrit.wikimedia.org/r/954913

Change 954955 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] Remove untranslated equal sign message from SearchPreview

https://gerrit.wikimedia.org/r/954955

Change 954914 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Use proper word and comma separator messages in SearchPreview

https://gerrit.wikimedia.org/r/954914

Change 954955 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Remove untranslated equal sign message from SearchPreview

https://gerrit.wikimedia.org/r/954955

Change 955280 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] Dramatically simplify boolean state management in ExpandablePane

https://gerrit.wikimedia.org/r/955280

WMDE-Fisch updated the task description. (Show Details)

The things done / planed here is as good as it gets IMO without rewriting the whole thing. I would consider this done when the patches linked are merged.

Change 954696 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Add seperator to search preview tags

https://gerrit.wikimedia.org/r/954696

Change 955866 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] Rename $buttonLabel to $buttonContent

https://gerrit.wikimedia.org/r/955866

Change 955883 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] [POC] Don't render default sort order in SearchPreview

https://gerrit.wikimedia.org/r/955883

Change 955866 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Rename $buttonLabel to $buttonContent

https://gerrit.wikimedia.org/r/955866

Change 954603 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Move label creation to ExpandablePane and make label explicit

https://gerrit.wikimedia.org/r/954603

Change 955280 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Dramatically simplify boolean state management in ExpandablePane

https://gerrit.wikimedia.org/r/955280

Change 954710 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Convert search preview tags into a list with a description

https://gerrit.wikimedia.org/r/954710