Cannot select input and output types for a function if you start on the object creation screen and then start creating a function
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DVrandecic
	Jul 26 2023, 6:57 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://www.wikifunctions.org/wiki/Special:CreateObject?view=function-editor

What happens?:

If I click on "+ Add an input" nothing happens
If I type "str" into the Output / Type field, I see String and other options, but I cannot select them

What should have happened instead?:
I should be able to add inputs.
I should be able to select an output type.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	Initialize blank function when redirecting to FunctionEditor from DefaultView	mediawiki/extensions/WikiLambda	master	+16 -9

Customize query in gerrit

Event Timeline

DVrandecic created this task.Jul 26 2023, 6:57 PM

ATsay-WMF subscribed.Jul 26 2023, 7:00 PM

Quiddity subscribed.Jul 26 2023, 7:08 PM

AAlhazwani-WMF subscribed.Jul 26 2023, 7:17 PM

gengh subscribed.Jul 26 2023, 10:01 PM

The direct link to creating a function is not with view=function-editor parameter but with zid=Z8. The correct url to directly access the function editor is https://www.wikifunctions.org/wiki/Special:CreateObject?zid=Z8

Going to https://www.wikifunctions.org/wiki/Special:CreateObject?view=function-editor is the same as going to the default create object page with no parameters https://www.wikifunctions.org/wiki/Special:CreateObject
When selecting Function in the type selector, there's an exception to redirect to the function editor page and initialize the function
It is after this redirect that the blank function is initialized incorrectly and the behavior that you observed happens.

We should fix the initialization of blank Function object after redirect from DefaultView

Jdforrester-WMF renamed this task from Cannot select input and output types for a function to Cannot select input and output types for a function if you start on the object creation screen and then start creating a function.Jul 26 2023, 10:11 PM

Jdforrester-WMF added a project: WikiLambda Front-end.

gengh claimed this task.Jul 26 2023, 10:13 PM

Change 942026 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Initialize blank function when redirecting to FunctionEditor from DefaultView

https://gerrit.wikimedia.org/r/942026

gerritbot added a project: Patch-For-Review.Jul 26 2023, 10:34 PM

Jdforrester-WMF moved this task from To triage to Verify in production on the Abstract Wikipedia team board.Jul 26 2023, 10:43 PM

Change 942026 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Initialize blank function when redirecting to FunctionEditor from DefaultView

https://gerrit.wikimedia.org/r/942026

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 26 2023, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2023, 11:10 PM

Jdforrester-WMF triaged this task as Medium priority.Jul 28 2023, 4:08 PM

DVrandecic closed this task as Resolved.Jul 28 2023, 11:41 PM

Cannot select input and output types for a function if you start on the object creation screen and then start creating a functionClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Cannot select input and output types for a function if you start on the object creation screen and then start creating a function
Closed, ResolvedPublicBUG REPORT
Actions