Page MenuHomePhabricator
Create Task
Maniphest T342935

IP masking: Temp account tooltip styles appear above other elements, button styles arent correct
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
GMikesell-WMF
Authored By
bwang
Jul 27 2023, 10:53 PM
Tags
Referenced Files
F37344985: T342935_IPMasking_TempAcct_Tooltip8.png
Aug 8 2023, 10:58 PM
F37344979: T342935_IPMasking_TempAcct_Tooltip7.png
Aug 8 2023, 10:58 PM
F37344974: T342935_IPMasking_TempAcct_Tooltip6.png
Aug 8 2023, 10:58 PM
F37344967: T342935_IPMasking_TempAcct_Tooltip5.png
Aug 8 2023, 10:58 PM
F37344877: T342935_IPMasking_TempAcct_Tooltip4.png
Aug 8 2023, 10:58 PM
F37344869: T342935_IPMasking_TempAcct_Tooltip3.png
Aug 8 2023, 10:58 PM
F37344863: T342935_IPMasking_TempAcct_Tooltip2.png
Aug 8 2023, 10:58 PM
F37344855: T342935_IPMasking_TempAcct_Tooltip1.png
Aug 8 2023, 10:58 PM
View All 9 Files
Subscribers
Aklapper
bwang
Edtadros
GMikesell-WMF
Jdlrobson
KSarabia-WMF
Masumrezarock100
View All 9 Subscribers

Description

Steps to replicate the issue (include links if applicable):

  • Become a temp users in Minerva
  • Open an overlay

What happens?:
The black outline from the tooltip shows above the overlay
https://phabricator.wikimedia.org/F37152477

What should have happened instead?:
The overlay should go on top of the tooltip, and the tooltip button shouldnt have any outline

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Developer notes

The 2 issues are both because of CSS thats applied to .mw-temp-user-banner-tooltip. These styles apply color: black, but actually messes up the codex button styles, and z-index, which also causes the button to go over overlays. both styles probably should be applied to the tooltip body rather than the container

QA steps

https://phabricator.wikimedia.org/T342935#9078074

QA Results - PatchDemo

ACStatusDetails
1✅Login Status
2✅Tooltip Button on Gray Bar
3✅Outline Check
4✅Overlay Interaction

Details

SubjectRepoBranchLines +/-
Tooltip fixmediawiki/coremaster+9 -8
Customize query in gerrit

Event Timeline

bwang created this task.Jul 27 2023, 10:53 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJul 27 2023, 10:53 PM
Jdlrobson renamed this task from Temp account tooltip styles appear above other elements, button styles arent correct to IP masking: Temp account tooltip styles appear above other elements, button styles arent correct.Jul 28 2023, 7:05 PM
Jdlrobson added a project: Temporary accounts.
Jdlrobson added a subscriber: ovasileva.
ovasileva triaged this task as Medium priority.Jul 28 2023, 8:36 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3); removed Web-Team-Backlog.
ovasileva set the point value for this task to 1.Jul 31 2023, 5:54 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
KSarabia-WMF claimed this task.Aug 1 2023, 7:31 PM
gerritbot added a comment.Aug 1 2023, 9:53 PM

Change 944324 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/core@master] Tooltip fix

https://gerrit.wikimedia.org/r/944324

gerritbot added a project: Patch-For-Review.Aug 1 2023, 9:53 PM
bwang moved this task from Ready for Development to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 4 2023, 5:28 PM
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 8 2023, 4:38 PM
gerritbot added a comment.Aug 8 2023, 4:46 PM

Change 944324 merged by jenkins-bot:

[mediawiki/core@master] Tooltip fix

https://gerrit.wikimedia.org/r/944324

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 8 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 8 2023, 5:10 PM
PatchDemoBot added a comment.Aug 8 2023, 5:24 PM

Test wiki created on Patch demo by KSarabia-WMF using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/c2bbf7a871/w

KSarabia-WMF added a comment.EditedAug 8 2023, 5:31 PM

QA Instructions

Go to Patch Demo
Go to Patch Demo
Login Status:

  1. Start by confirming that you are not logged into any user account on Mediawiki
  2. Navigate to a page on the web application where anonymous editing is allowed.
  3. Attempt to edit the page without logging in. Verify that the edits are allowed and saved successfully.
  4. After editing, check if a gray bar appears at the top of the page, spanning the full width.
  5. The gray bar should display the message "You are using a temporary account."

Tooltip Button on Gray Bar:

  1. Locate the tooltip button on the gray bar, often denoted by an "i" icon or similar.
  2. Click the tooltip button and observe the behavior.
  3. Confirm that the tooltip box content is accurate and easily readable.

Outline Check:

  1. While the gray bar tooltip is open, check for the presence of an outline around the tooltip box.
  2. There should be no visible outline around the tooltip box.

Overlay Interaction:

  1. Click on a UI element that would trigger an overlay, such as the search bar.
  2. Confirm that the overlay renders on top of the gray bar, without any visual glitches or misplacements.
  3. While the overlay is active, inspect for any outlines or borders appearing within the overlay.
Jdlrobson updated the task description. (Show Details)Aug 8 2023, 5:46 PM
Jdlrobson reassigned this task from KSarabia-WMF to Mhurd.Aug 8 2023, 6:22 PM
Jdlrobson added subscribers: Edtadros, Mhurd, KSarabia-WMF, Jdlrobson.

Hey @Mhurd adding you since @Edtadros is winding down. Feel free to reassign to George if they'll be handling QA.

PatchDemoBot added a comment.Aug 8 2023, 9:07 PM

Test wiki on Patch demo by KSarabia-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/c2bbf7a871/w/

GMikesell-WMF subscribed.EditedAug 8 2023, 10:58 PM

Status: ✅ PASS
Environment: Patch Demo
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Links:
https://patchdemo.wmflabs.org/wikis/0a1cc370e2/wiki/Main_Page
To test Search Bar: https://patchdemo.wmflabs.org/wikis/0a1cc370e2/wiki/index.php?useskin=minerva

✅AC1: Login Status- Edits are saved, Grey bar is full width and displays "You are using a temporary account."

T342935_IPMasking_TempAcct_Tooltip.png (889×2 px, 208 KB)

✅AC2: ✅AC3: Tooltip Button on Gray Bar & Outline Check- 'i" icon or light bulb (Arabic) works as designed. No visible outline around the tooltip box.

EnglishSpanishHebrewArabic
T342935_IPMasking_TempAcct_Tooltip1.png (362×642 px, 40 KB)
T342935_IPMasking_TempAcct_Tooltip2.png (305×677 px, 42 KB)
T342935_IPMasking_TempAcct_Tooltip3.png (359×656 px, 35 KB)
T342935_IPMasking_TempAcct_Tooltip4.png (285×538 px, 39 KB)

✅AC4: Overlay Interaction- Overlay renders over the gray bar with no glitches or misplacements

EnglishSpanishHebrewArabic
T342935_IPMasking_TempAcct_Tooltip5.png (457×3 px, 70 KB)
T342935_IPMasking_TempAcct_Tooltip6.png (199×3 px, 18 KB)
T342935_IPMasking_TempAcct_Tooltip7.png (307×3 px, 25 KB)
T342935_IPMasking_TempAcct_Tooltip8.png (239×3 px, 59 KB)
GMikesell-WMF claimed this task.Aug 8 2023, 10:59 PM
GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
GMikesell-WMF updated the task description. (Show Details)Aug 9 2023, 3:00 PM
ovasileva closed this task as Resolved.Aug 9 2023, 3:14 PM

Looks good, resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL