Page MenuHomePhabricator

Amend Wikimedia Design System`#d33` to `#d73333`
Closed, ResolvedPublic5 Estimated Story Points

Description

Background

With decision on T337444: Destructive normal and quiet buttons fail WCAG AA contrast to change Red600 of before #d33 to slightly darker #d73333 to also enable sufficient color contrast on light gray backgrounds, we also need to update the color in scattered projects across teams.

Current codebase search.

It's advisable to use Large-Scale Changes tool for it.

Goal

Replace #d33 with #d73333 in MediaWiki core, extensions and skins for consistency and to set clear example for volunteers as well, who are working in their extensions and orient on code from Vector and other extensions.
This task applies to all, colors, background colors and border colors.

Acceptance criteria

  • Use the LSC tool to find all relevant codebases and open patches that update the relevant color to the correct value
    • In CSS files we should go with the hex color
    • In Less files we should consider @color-destructive or @color-error when it's the right application.

Details

Other Assignee
Volker_E
SubjectRepoBranchLines +/-
operations/deployment-chartsmaster+2 -2
mediawiki/coremaster+1 -1
mediawiki/coremaster+352 -290
mediawiki/extensions/MassMessagemaster+1 -1
mediawiki/extensions/Quizmaster+3 -3
mediawiki/extensions/CentralNoticemaster+3 -3
mediawiki/extensions/VisualEditormaster+1 -1
mediawiki/extensions/VisualEditormaster+2 -2
VisualEditor/VisualEditormaster+2 -2
wikibase/termboxmaster+1 -1
mediawiki/skins/MinervaNeuemaster+1 -1
mediawiki/extensions/Wikibasemaster+1 -1
mediawiki/extensions/EventLoggingmaster+1 -1
mediawiki/skins/Timelessmaster+2 -2
mediawiki/extensions/PageTriagemaster+1 -1
mediawiki/coremaster+10 -10
mediawiki/extensions/CodeMirrormaster+1 -1
mediawiki/extensions/CodeMirrormaster+1 -1
mediawiki/skins/WikimediaApiPortalmaster+1 -1
mediawiki/skins/Timelessmaster+1 -1
mediawiki/extensions/DonationInterfacemaster+1 -1
mediawiki/extensions/VisualEditormaster+1 -1
mediawiki/extensions/BetaFeaturesmaster+1 -1
mediawiki/skins/MinervaNeuemaster+1 -1
oojs/uimaster+34 -34
mediawiki/coremaster+53 -53
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 1005611 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Design System: update #d33 to #d73333

https://gerrit.wikimedia.org/r/1005611

Change 1005611 abandoned by LWatson:

[mediawiki/core@master] Design System: update #d33 to #d73333

Reason:

The changes should not affect lib/ooui

https://gerrit.wikimedia.org/r/1005611

Change 1005813 had a related patch set uploaded (by Jforrester; author: Jforrester):

[oojs/ui@master] icons: Update 'destructive' colour from #d33 to #d73333

https://gerrit.wikimedia.org/r/1005813

Change 1005813 merged by jenkins-bot:

[oojs/ui@master] icons: Update 'destructive' colour from #d33 to #d73333

https://gerrit.wikimedia.org/r/1005813

Volker_E updated the task description. (Show Details)

Change 1006878 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/skins/MinervaNeue@master] styles: Update color in Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1006878

Change 1006878 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] styles: Update color in Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1006878

Change 1006884 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/extensions/BetaFeatures@master] styles: Update color in Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1006884

Change 1006884 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] styles: Update color in Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1006884

Change 1006885 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/skins/Timeless@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1006885

CCiufo-WMF changed the task status from Open to In Progress.Feb 29 2024, 5:27 PM

Change 1006885 abandoned by LWatson:

[mediawiki/skins/Timeless@master] styles: Update color in CSS from #d33 to #d73333

Reason:

disregard because it's a volunteer maintained project

https://gerrit.wikimedia.org/r/1006885

Change 1007669 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/extensions/DonationInterface@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1007669

Change 1007670 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/extensions/VisualEditor@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1007670

Change 1006885 restored by LWatson:

[mediawiki/skins/Timeless@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1006885

Change 1007670 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1007670

Change 1007669 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1007669

Change 1006885 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] styles: Update error color from #d33 to #d73333

https://gerrit.wikimedia.org/r/1006885

Change rOPUP10089242fcba had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/CodeMirror@master] styles: Update color in Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1008924

Change 1008925 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/skins/WikimediaApiPortal@master] styles: Update color in Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1008925

Change 1009370 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] styles: Update color in CSS and Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1009370

Change rOPUP10089242fcba merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] styles: Update color in Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1008924

Change 1010231 had a related patch set uploaded (by VolkerE; author: VolkerE):

[VisualEditor/VisualEditor@master] styles: Update error colors from #d33

https://gerrit.wikimedia.org/r/1010231

Change 1008925 merged by jenkins-bot:

[mediawiki/skins/WikimediaApiPortal@master] styles: Update color in Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1008925

Change 1010267 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/VisualEditor@master] styles: Update error colors from #d33

https://gerrit.wikimedia.org/r/1010267

Change 1010318 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CodeMirror@master] styles: Replace error color with `#d73333`

https://gerrit.wikimedia.org/r/1010318

Change 1010318 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] styles: Replace error color with `#d73333`

https://gerrit.wikimedia.org/r/1010318

Change 1009370 merged by jenkins-bot:

[mediawiki/core@master] styles: Update color in CSS and Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1009370

Change 1010264 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/EventLogging@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010264

Change 1010265 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/PageTriage@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010265

Change 1010666 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/VisualEditor@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010666

Change 1010667 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Wikibase@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010667

Change 1010668 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/skins/Timeless@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010668

Change 1010265 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010265

Change 1010684 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/skins/MinervaNeue@master] styles: Update color in SVG from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010684

Change 1010946 had a related patch set uploaded (by LWatson; author: LWatson):

[wikibase/termbox@master] styles: Update color in SVG from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010946

Change 1010668 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] styles: Update color in CSS and Less from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010668

Change 1010264 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010264

Change 1010667 abandoned by LWatson:

[mediawiki/extensions/Wikibase@master] styles: Update color in CSS from #d33 to #d73333

Reason:

the extension relies on wikimedia-ui-base (deprecated)

https://gerrit.wikimedia.org/r/1010667

Change 1010684 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] styles: Update color in SVG from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010684

Change 1010946 merged by jenkins-bot:

[wikibase/termbox@master] styles: Update color in SVG from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010946

Change 1010231 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] styles: Update error colors from #d33

https://gerrit.wikimedia.org/r/1010231

Change 1010666 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] styles: Update color in CSS from #d33 to #d73333

https://gerrit.wikimedia.org/r/1010666

Change 1011375 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (504b8d5e8)

https://gerrit.wikimedia.org/r/1011375

Change 1011375 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (504b8d5e8)

https://gerrit.wikimedia.org/r/1011375

Change #1016082 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CentralNotice@master] styles: Update color in from #d33 to #d73333

https://gerrit.wikimedia.org/r/1016082

Change #1016115 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MassMessage@master] styles: Update color in from #d33 to #d73333

https://gerrit.wikimedia.org/r/1016115

Change #1016253 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Quiz@master] styles: Update color in from #d33 to #d73333

https://gerrit.wikimedia.org/r/1016253

Change #1016082 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] styles: Update color in from #d33 to #d73333

https://gerrit.wikimedia.org/r/1016082

Change #1016253 merged by jenkins-bot:

[mediawiki/extensions/Quiz@master] styles: Update color in from #d33 to #d73333

https://gerrit.wikimedia.org/r/1016253

Change #1016115 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] styles: Update color in from #d33 to #d73333

https://gerrit.wikimedia.org/r/1016115

Volker_E updated the task description. (Show Details)
Volker_E removed a project: Patch-For-Review.

This is resolved \o/
Thanks to @lwatson for the pro-active work and collaboration here!

Change #1017120 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update OOUI to v1.2.34

https://gerrit.wikimedia.org/r/1017120

Change #1017120 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.49.1

https://gerrit.wikimedia.org/r/1017120

Change #1017170 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] rcfilters: Change destructive color to `#d73333`

https://gerrit.wikimedia.org/r/1017170

Change #1017170 merged by jenkins-bot:

[mediawiki/core@master] rcfilters: Change destructive color to `#d73333`

https://gerrit.wikimedia.org/r/1017170

Change #1007643 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/deployment-charts@master] termbox: update to 2024-03-14-121904-production

https://gerrit.wikimedia.org/r/1007643

Change #1007643 merged by jenkins-bot:

[operations/deployment-charts@master] termbox: update to 2024-03-14-121904-production

https://gerrit.wikimedia.org/r/1007643