SyntaxError: Failed to execute 'evaluate' on 'Document': The string '' is not a valid XPath expression.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Aug 1 2023, 8:34 PM

Description

Error

logstash link

normalized_message

SyntaxError: Failed to execute 'evaluate' on 'Document': The string '' is not a valid XPath expression.

exception.trace

stack_trace:
at Object.e  chrome://internal-624f9048-5f4f-4ce2-bb15-70f241b9fcce/:1:39291
at Object.l  chrome://internal-624f9048-5f4f-4ce2-bb15-70f241b9fcce/:1:906

error_context.namespace: Special

error_context.skin: minerva
	
error_context.special_page: CreateAccount
	
error_context.version: 1.41.0-wmf.19

file_url: chrome://internal-624f9048-5f4f-4ce2-bb15-70f241b9fcce/

Impact

109 errors in 24 hours

Notes

There was a similar task filed as T299500

Details

	Subject	Repo	Branch	Lines +/-
	clientError: Add chrome:// to URI schema ban list	mediawiki/extensions/WikimediaEvents	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T299500: SyntaxError: Failed to execute 'evaluate' on 'Document': The string '//form[@method='post' or @method='POST']/descendant::button[@type='submit]' is not a valid XPath expression.
Mentioned Here: T299500: SyntaxError: Failed to execute 'evaluate' on 'Document': The string '//form[@method='post' or @method='POST']/descendant::button[@type='submit]' is not a valid XPath expression.

Event Timeline

Etonkovidova created this task.Aug 1 2023, 8:34 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 1 2023, 8:34 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

file_url: chrome://internal-624f9048-5f4f-4ce2-bb15-70f241b9fcce/

Not sure what this is but I doubt we can do much about it.

@Jdlrobson should we filter these like we filter chrome-extension://?

These are already filtered out on the mw-client-NEW-errors board: https://logstash.wikimedia.org/app/dashboards#/view/AXDBY8Qhh3Uj6x1zCF56?_g=h@218e8f9&_a=h@03605df - which board are you using? You should definitely filter those out.

We have filtering in the associated alert here so these errors do not contribute to alerts and can be safely ignored :
https://gerrit.wikimedia.org/g/operations/puppet/+/refs/changes/45/938945/2/modules/prometheus/files/es_exporter/20-client-error.cfg#33

We use mw-client-growth-team-errors. We can update that - it seems weird though that we filter some URL schemas in the client-side reporting logic and some in logstash. Wouldn't it make more sense to do it all in one place (presumably on the client-side because that's more privacy friendly)?

We did this for file uris, I forget why we didn't do it for stack traces. I vaguely remember concern about the growing size of the client, but I personally don't think there is much value in logging these errors: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/654470/3/modules/ext.wikimediaEvents/clientError.js

This is about file URIs, we just didn't ban chrome://, only chrome-extension://.

Ah yeh that looks like a bug. Patch welcome! If you want to write it I'll merge it!

Change 945885 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/WikimediaEvents@master] clientError: Add chrome:// to URI schema ban list

https://gerrit.wikimedia.org/r/945885

gerritbot added a project: Patch-For-Review.Aug 4 2023, 11:52 PM

Change 945885 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] clientError: Add chrome:// to URI schema ban list

https://gerrit.wikimedia.org/r/945885

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2023, 12:30 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 5 2023, 1:00 AM

Tgr closed this task as Resolved.Aug 5 2023, 4:40 AM

Tgr claimed this task.

Tgr mentioned this in T299500: SyntaxError: Failed to execute 'evaluate' on 'Document': The string '//form[@method='post' or @method='POST']/descendant::button[@type='submit]' is not a valid XPath expression..

SyntaxError: Failed to execute 'evaluate' on 'Document': The string '' is not a valid XPath expression.Closed, ResolvedPublicActions