Page MenuHomePhabricator

PageTriage Rename ui_version feature flag to pagetriage_ui
Closed, ResolvedPublic

Description

Upon resolving issues with the Special:NewPagesFeed Vue UI, we will promote it to the default experience, and demote the backbone version to a feature flag.
Once we had the ui_version flag live, I realized it was pretty poorly named given it's coexistence with every other feature flag on wiki, so this is a good opportunity to change it.
We landed on pagetriage_ui.

Original:

Upon resolving issues with the Special:NewPagesFeed Vue UI, we will promote it to the default experience, and demote the backbone version to a feature flag.

Because the toolbar and the feed share some state, the changes will need to be made to both together. The partially migrated toolbar shares state with the Vue version of Special:NewPagesFeed, and the pure Backbone version of the toolbar shares state with the Backbone version of Special:NewPagesFeed.

Once we had the ui_version flag live, I realized it was pretty poorly named given it's coexistence with every other feature flag on wiki, so this is a good opportunity to change it.

I suggest e.pt.ui=bb or something similar to clearly scope the query parameter to PageTriage, but we can discuss it here while we're still resolving the remaining tasks.

We should also discuss a timetable for removing the migrated backbone bits altogether; I'd suggest keeping it as low as one or two trains if there are no major problems after making the switch.

Because the partial toolbar migration is designed to allow incremental migration, there shouldn't be a need for the feature flag as it exists now which swaps out entire resource loader modules. If there is still a desire for a feature flag for future migration steps on the toolbar, it can be scoped to individual buttons.

Event Timeline

?e.pt.ui=bb isn't very readable. I'd be in favor of something like ?pagetriage_ui=old

Scardenasmolinar changed the task status from Open to In Progress.Aug 23 2023, 1:48 AM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change 952293 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Rename new UI feature flag

https://gerrit.wikimedia.org/r/952293

  • Are we going to have a beta test for the Page Curation toolbar rewrite?
  • Should we give it a different feature flag than the Special:NewPagesFeed rewrite?
  • How will we drive traffic to the Page Curation toolbar rewrite? We'd probably need to add &pagetriage_ui=2 or whatever the feature flag is to all the links in Special:NewPagesFeed. Copy pasting that feature flag to the end of each URL seems impractical.

Rough draft idea:

  • &pagetriage_ui unset - Backbone everything
  • &pagetriage_ui=1 - Special:NewPagesFeed vue rewrite
  • &pagetriage_ui=2 - Special:NewPagesFeed vue rewrite, AND page curation toolbar vue rewrite, AND links in Special:NewPagesFeed get appended with &ui_version=2

This task is meant to be after the beta testing is wrapped and we want to make vue the default experience, @Scardenasmolinar is just working through it a little bit in advance since the feature flagging can be thought through separately from the feature itself.

These are good questions and thoughts; I'll respond inline with what I was thinking when I wrote this up:

  • Are we going to have a beta test for the Page Curation toolbar rewrite?

Yes, though that can only start after T340130: Implement Curation Toolbar container in Vue.js gets merged in.

  • Should we give it a different feature flag than the Special:NewPagesFeed rewrite?

I had envisioned a single feature flag for simplicity.

  • How will we drive traffic to the Page Curation toolbar rewrite?

The current patch for T340130: Implement Curation Toolbar container in Vue.js simply adds the feature flag to the review button links; so if you are testing the new feed, you also test the new toolbar.

Rough draft idea:

These really make sense to talk about in T340130: Implement Curation Toolbar container in Vue.js, so I'll move the discussion there:

Scardenasmolinar changed the task status from In Progress to Stalled.Aug 29 2023, 4:44 PM
Scardenasmolinar moved this task from Backlog to Code Review on the PageTriage board.

I know we don't want to change the parameter name just yet, but this change is ready for review. I'll mark it as stalled so we don't merge it.

Samwalton9-WMF changed the task status from Stalled to Open.Sep 19 2023, 4:13 PM

Change 952293 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Rename new UI feature flag

https://gerrit.wikimedia.org/r/952293

So, the original plan was to deploy the toolbar and new pages feed together, but given how long the toolbar has been held up, we'll just split it up with a separate feature flag. we've gone with pagetriage_ui for the new pages feed, so I'm thinking pagetriage_tb for the toolbar. I'll update the toolbar patch so that the new pages feed can check for the toolbar feature flag and pass it on in the review links.

jsn.sherman renamed this task from PageTriage Remove ui_version feature flag and add a better-named flag to access backbone ui to PageTriage Remove ui_version feature flag to pagetriage_ui.Oct 6 2023, 12:39 AM
jsn.sherman renamed this task from PageTriage Remove ui_version feature flag to pagetriage_ui to PageTriage Rename ui_version feature flag to pagetriage_ui.
jsn.sherman changed the task status from Open to In Progress.
jsn.sherman updated the task description. (Show Details)
jsn.sherman moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.
jsn.sherman moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.